Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitor demo applications #267

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix monitor demo applications #267

merged 1 commit into from
Jan 11, 2024

Conversation

sgraband
Copy link
Contributor

Use latest community release.
Update to CRs from now on.

VSCode demo:

  • Fix plugins folder location

Theia extension demo:

  • Make Theia dependencies of extension peerDependencies.
  • Build the demo with the local extension for easier testing.
  • Make sure that the test directory is not cleared
    • This crashed the plugins

Contributed on behalf of STMicroelectronics

Use latest community release. Update to CRs from now on.

VSCode demo:
- Fix plugins folder location

Theia extension demo:
- Make Theia dependencies of extension peerDependencies.
- Build the demo with the local extension for easier testing.
- Make sure that the test directory is not cleared
    - This crashed the plugins

Contributed on behalf of STMicroelectronics

Co-authored-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested locally on Minikube

@sgraband sgraband merged commit 23ed108 into main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants