node: Stabilize next version calculation for common and monitor-theia #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the next version calculation used `npm pkg get version`. It turned out that its output is instable and even changes across minor node version upgrades. This uses an inline node script (like the reusable workflow) to directly extract the version from the package.json.
sgraband
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the next version calculation used
npm pkg get version. It turned out that its output is instable and even changes across minor node version upgrades.This uses an inline node script (like the reusable workflow) to directly extract the version from the package.json.
I tested the next version calculation by removing the actual publish from the publish:next command and then executing it locally. This updated the version in the package.json as expected for me.