Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize & apply standard formatting #325

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Standardize & apply standard formatting #325

merged 9 commits into from
Jul 19, 2024

Conversation

sgraband
Copy link
Contributor

Standardize the formatting for the use in VSCode.
Use the java-formatter.xml file together with the vscjava.vscode-java-pack for Java formatting.
Define prettier as the default formatter for most of the files.
Exceptions include:

  • dockerfiles are formatted using ms-azuretools.vscode-docker
  • plantuml files are formatted using jebbs.plantuml

Also add all needed extensions to the recommendations.
Furthermore, transform all launch configs to tasks & debug configs.

Fixes #152

@jfaltermeier
Copy link
Contributor

I pushed an additional commit. Some of the xml files still had tabs.
VS Code did not update these, the Theia IDE did. After it was fixed, VS Code also produces spaces instead of tabs.
Not sure what was/is the issue there.
Could you maybe shortly check if you can also change the xml files now without any additional changes?

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it looks good.
Formatting seems to work and the the debug configurations / tasks also work.
If we notice any inconsistencies, we need to log new issues.

In general we should probably also add more documentation on how to run the theia cloud services locally, because e.g. the conversion webhook currently fails with java.nio.file.NoSuchFileException: /etc/webhook/certs/tls.crt, since this path is hard-coded in the application.properties

But this is out of context for this PR

@sgraband
Copy link
Contributor Author

@jfaltermeier Thanks for the commit. For me both Theia IDE and VSCode do not change the formatting with tabs/whitespaces. So i can no longer reproduce that issue, so we should be good to go. More documentation regarding building locally definately makes sense, but i also agree that this should be done in a follow up 👍

@jfaltermeier jfaltermeier merged commit 37785cf into main Jul 19, 2024
15 checks passed
@jfaltermeier jfaltermeier deleted the vscodeConfig branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize & apply standard formatting
2 participants