Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Kubernetes resource naming and set up common unit tests #326

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Rework Kubernetes resource naming and set up common unit tests #326

merged 4 commits into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. GH-324: Rework Kubernetes resource naming and set up common unit tests 

    Rework the naming of Kubernetes resources for workspaces and sessions
in the common package used by operator and service.

The goal is to make resource names more readable and contain useful information.
Resource names now contain a prefix, optional identifier, user, app definition and
the last segment of the source CRs (session, workspace, app definition) UID.

Also configure unit tests using JUnit 5 for the common maven module
and add some tests for the new name generation.
    @lucas-koehler
    lucas-koehler committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    10eedf5 View commit details
    Browse the repository at this point in the history

  2. Shorten workspace prefix to ws

    @lucas-koehler
    lucas-koehler committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b0835b6 View commit details
    Browse the repository at this point in the history

  3. Explicitly configure java formatting tab size to 4 spaces 

    The setting from the java-formatter.xml does not seem to be respected.
Set the tab width explicitly via `editor.tabSize` to ensure this works independently of the VSCode settings regarding tab size.
    @lucas-koehler
    lucas-koehler committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d7a8a0c View commit details
    Browse the repository at this point in the history

  4. Fix and format NamingUtilTests

    @lucas-koehler
    lucas-koehler committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1193bcf View commit details
    Browse the repository at this point in the history