Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial packaging #1

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

Mailaender
Copy link
Contributor

@Mailaender Mailaender commented Sep 24, 2024

Copy link

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this looks good.
I tried testing it on my 22.04 machine, but I keep getting "Timed out waiting for networking to be ready" after running snapcraft at the moment.

.github/workflows/publish.yml Show resolved Hide resolved
@Mailaender
Copy link
Contributor Author

@jfaltermeier
Copy link

@jfaltermeier I assume you may be running Docker as well. There is a known issue https://documentation.ubuntu.com/lxd/en/latest/howto/network_bridge_firewalld/#prevent-connectivity-issues-with-lxd-and-docker

Thanks, I've managed to get a build now, but the result doesn’t seem to work. Are you seeing the same issue? For me, the mode of the file is 755:

~$ snap list | grep theia
theia-ide          1.52.0           x1     -                -              -

~$ which theia-ide
/snap/bin/theia-ide

~$ theia-ide
[68213:1001/114800.047645:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing, I'm aborting now. You need to make sure that /snap/theia-ide/x1/opt/TheiaIDE/chrome-sandbox is owned by root and has mode 4755.
Trace/breakpoint trap

@Mailaender
Copy link
Contributor Author

I am not acquainted with that error. Did you install as instructed?

sudo snap install theia-ide*.snap --dangerous --classic

@jfaltermeier
Copy link

Yes, but I did get a warning:

$ sudo snap install theia-ide*.snap --dangerous --classic
Warning: flag --classic ignored for strictly confined snap theia-ide

The .deb works fine.

When I changed the confinement: strict to classic in the snapcraft.yaml, it worked for me. Based on what I’ve read about the differences between strict and classic confinement, it seems like classic makes sense for an IDE, right? Since it needs access to source code files and possibly tools for compiling.

@Mailaender
Copy link
Contributor Author

Mailaender commented Oct 2, 2024

Updated this for classic confinement as it was just approved at https://forum.snapcraft.io/t/classic-confinement-for-eclipse-theia-ide/42177/6

Copy link

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaltermeier jfaltermeier merged commit 62212ae into eclipse-theia:master Oct 2, 2024
1 check passed
@Mailaender Mailaender deleted the 1.52.0 branch October 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants