Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prerequisites] node 10 instead of 8 #30

Merged
merged 1 commit into from
Aug 4, 2019
Merged

[prerequisites] node 10 instead of 8 #30

merged 1 commit into from
Aug 4, 2019

Conversation

akosyakov
Copy link
Member

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did not re-test the instructions with node 10.

@akosyakov
Copy link
Member Author

Latest version of Theia is not compatible with node 8, merging

@akosyakov akosyakov merged commit d6718b1 into master Aug 4, 2019
@akosyakov akosyakov deleted the ak/node_10 branch August 4, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants