doc: Add page on authoring VS Code extensions #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
force-pushed
the
planger/issues/316
branch
3 times, most recently
from
ec30f34
to
1c04254
Compare
There was a problem hiding this comment.
@planger overall the changes look really good, I only have minor suggestions if interested 👍
|
|
||
| # Authoring VS Code Extensions | ||
|
|
||
| Alongside [Theia extensions](https://theia-ide.org/docs/extensions#theia-extensions), also VS Code extensions can be used to enhance Theia applications with additional functionality, such as language support, status bar items, or tree views. |
There was a problem hiding this comment.
minor:
Suggested change
| Alongside [Theia extensions](https://theia-ide.org/docs/extensions#theia-extensions), also VS Code extensions can be used to enhance Theia applications with additional functionality, such as language support, status bar items, or tree views. | |
| Alongside [Theia extensions](https://theia-ide.org/docs/extensions#theia-extensions), VS Code extensions can also be used to enhance Theia applications with additional functionality, such as language support, status bar items, or tree views. |
For the three examples we list, we might want to choose the most common, for example language support, commands, tree-views, but I don't have a strong opinion.
Comment on lines
8
to
9
| VS Code extensions contribute functionality through a dedicated extension API, originally defined for VS Code. | ||
| Theia, however, supports the extension API of VS Code, making extensions that have been developed for VS Code compatible to Theia, and vice versa. |
There was a problem hiding this comment.
minor: only a suggestion:
Suggested change
| VS Code extensions contribute functionality through a dedicated extension API, originally defined for VS Code. | |
| Theia, however, supports the extension API of VS Code, making extensions that have been developed for VS Code compatible to Theia, and vice versa. | |
| VS Code extensions contribute functionality through the dedicated VS Cide API, which the Theia framework also supports. This means that extensions that have been developed for VS Code are also compatible with Theia, and vice versa. |
Comment on lines
91
to
92
| 1. Pre-installing the VS Code extension in your Theia application | ||
| 2. Enabling your users to install your VS Code extensions at runtime |
There was a problem hiding this comment.
minor: I believe the bullet points should be tabbed so they render correctly:
There was a problem hiding this comment.
Unfortunately tabbing wasn't sufficient, but I added a CSS rule for ol corresponding to the existing rule for ul.
planger
force-pushed
the
planger/issues/316
branch
from
1c04254
to
38fc4f8
Compare
Fixes eclipse-theia#316 Contributed on behalf of STMicroelectronics.
planger
force-pushed
the
planger/issues/316
branch
from
05f0c11
to
8c2bfcb
Compare
|
Thanks @vince-fugnitto for your feedback and suggestions! in 38fc4f8 I've applied all of them. |
JonasHelming
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316
Contributed on behalf of STMicroelectronics.