Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Theia IDE #470

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Add Theia IDE #470

merged 6 commits into from
Dec 28, 2023

Conversation

JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Nov 6, 2023 •
edited
Loading

fixed #468

  • Fix margins
  • Refine feature videos
  • Fix all references to Blueprint on remaining website including documentation
  • Complete VS Code extension gallery with links and more entries
  • Integrate logo well, e.g. on the top right corner

this this as a follow up: #485

@JonasHelming JonasHelming marked this pull request as draft November 6, 2023 15:12
@emilhammarstedtst
Copy link

Dark mode!?
Screenshot from 2023-11-07 16-20-15

@JonasHelming JonasHelming force-pushed the GH-468 branch 3 times, most recently from 30027de to c164ecc Compare November 12, 2023 12:32
@JonasHelming JonasHelming force-pushed the GH-468 branch 8 times, most recently from 686e24f to a463f38 Compare November 24, 2023 09:14
@JonasHelming JonasHelming force-pushed the GH-468 branch 3 times, most recently from a14151f to 74e5c29 Compare November 30, 2023 09:19
@JonasHelming
Add Theia IDE
275c001 
fixed #468

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming requested a review from planger December 5, 2023 18:48
planger
planger reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you very much! I found just two minors which I marked inline.

src/components/index/TheiaIDEDownloads.js Outdated Show resolved Hide resolved
src/components/index/TheiaIDEDownloads.js Outdated Show resolved Hide resolved
JonasHelming and others added 2 commits December 6, 2023 00:31
@JonasHelming @planger
Update src/components/index/TheiaIDEDownloads.js
2cd04ec 
Co-authored-by: Philip Langer <planger@eclipsesource.com>
@JonasHelming @planger
Update src/components/index/TheiaIDEDownloads.js
b6885b5 
Co-authored-by: Philip Langer <planger@eclipsesource.com>
@JonasHelming JonasHelming marked this pull request as ready for review December 5, 2023 23:34
@JonasHelming
Copy link
Contributor Author

@planger I committed your suggestions, thanks, could you apporve?

@JonasHelming JonasHelming requested a review from planger December 7, 2023 12:53
planger
planger approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

In the preview though, the padding of the buttons in the main banner on top seems to be missing now:
image

Except for that, I think this is all perfect! Thank you!

@JonasHelming
Copy link
Contributor Author

Hmm, the padding works for me locally, but also here in the preview :-/

@JonasHelming
Merge branch 'master' into GH-468
7cffd74 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming merged commit 66594cd into master Dec 28, 2023
5 checks passed
@msujew msujew mentioned this pull request Feb 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Theia IDE"
3 participants
@JonasHelming @emilhammarstedtst @planger