Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and Node #642

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Update dependencies and Node #642

merged 5 commits into from
Nov 8, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #641

Everything should look as before, but the slider buttons are blue, as they are links.

fixed #641

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

Do you have an idea why it tries to build with Node 14? I updated the workflows. It builds locally with Node 20

@jfaltermeier
Copy link
Contributor

Do you have an idea why it tries to build with Node 14? I updated the workflows. It builds locally with Node 20

I think this might be because the trigger is set to pull_request_target, which, as I understand it, runs the workflow from master rather than the updated one.

Temporarily changing it to pull_request might help to get a single test run with the updated workflow, though I’m not sure if there are any restrictions.

Copy link

github-actions bot commented Nov 7, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-08 11:12 UTC

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@jfaltermeier
Copy link
Contributor

I noticed that when I resize the window to a smaller width, the sliders can overlap with the images:
ksnip_20241107-135916

@JonasHelming
Copy link
Contributor Author

I noticed that when I resize the window to a smaller width, the sliders can overlap with the images:
Yes, I personally find this acceptable. Alterntive would be to switch to show only two items earlier, which looks much weirder, IMHO

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

@jfaltermeier I also had to update the setup-node task, but now the build runs

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@jfaltermeier
Copy link
Contributor

I noticed that when I resize the window to a smaller width, the sliders can overlap with the images:
Yes, I personally find this acceptable. Alterntive would be to switch to show only two items earlier, which looks much weirder, IMHO

Fine by me. Once we switch back to pull_request_target, we can merge this.

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

@jfaltermeier see latest commit, please re approve

@JonasHelming JonasHelming merged commit dc8171f into master Nov 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies and Node
2 participants