Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Theia IDE and platform website #659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Split Theia IDE and platform website #659

wants to merge 4 commits into from

Conversation

JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Nov 21, 2024

fixed #658

This PR is focussed on the Split only, it does not contain any further optimizations (which are now easier).
I am happy for any feedback, if possible in two categories:

  1. Necessary before we merge the split
  2. Further optimizations to be done after the split

Copy link

github-actions bot commented Nov 21, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-659/
on branch previews at 2024-11-24 14:14 UTC

@MatthewKhouzam
Copy link
Contributor

This looks great, I think it's much clearer than the current page.

@tsmaeder
Copy link

@JonasHelming the new site has a bunch of links to https://eclipse-theia.github.io/, which is a 404. Is that expected?

@JonasHelming
Copy link
Contributor Author

@JonasHelming the new site has a bunch of links to https://eclipse-theia.github.io/, which is a 404. Is that expected?

Example please? I believe these are the typeDoc links, see: #651

@tsmaeder
Copy link

When I click on the prominent "Explore the Theia Platform" button

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

When I click on the prominent "Explore the Theia Platform" button

This was, because it opened in new window, I fixed this. Please note that the preview is hosted on github.io, but links should still work. If they don't there is something wrong, so please give me all examples.

@tsmaeder
Copy link

@JonasHelming in the latest deployment https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-659/ the link still does not work (404)

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

@JonasHelming in the latest deployment https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-659/ the link still does not work (404)

Sorry, please check again and please let me know the other examples

@@ -104,7 +104,8 @@ const TheiaIDEDownloads = () => (
Help us make the Theia IDE even better, by <a href="https://github.com/eclipse-theia/theia/discussions">sharing your experience and suggestions</a>.
The features found in the Eclipse Theia IDE are based on Eclipse Theia and the available extensions/plugins. For more details please see the <a href="https://github.com/eclipse-theia/theia">Eclipse Theia GitHub Repository</a>. The Eclipse Theia IDE only packages existing Eclipse Theia functionality and installers. If you believe there is a mistake in packaging, something needs to be added to the packaging or the installers do not work properly, please <a href="https://github.com/eclipse-theia/theia-blueprint/issues/new/choose">open an issue on GitHub</a> to let us know.
<h1>Support</h1>
Need help with Theia? To get support by the community go to the <a href="https://github.com/eclipse-theia/theia/discussions">Discussions at GitHub</a>. To get professional support for Theia see the <a href="./support/">support page</a>.
Please refer to the <a href="/docs/user_getting_started/">Theia IDE Documentation</a>.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one gives a 404

<Footer background={true} />
</Layout>
)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your IDE set to remove trailing newlines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the one after {true} ?

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Platform and Theia IDE website
3 participants