-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Theia IDE and platform website #659
base: master
Are you sure you want to change the base?
Conversation
|
This looks great, I think it's much clearer than the current page. |
@JonasHelming the new site has a bunch of links to https://eclipse-theia.github.io/, which is a 404. Is that expected? |
Example please? I believe these are the typeDoc links, see: #651 |
When I click on the prominent "Explore the Theia Platform" button |
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
This was, because it opened in new window, I fixed this. Please note that the preview is hosted on github.io, but links should still work. If they don't there is something wrong, so please give me all examples. |
@JonasHelming in the latest deployment https://eclipse-theia.github.io/theia-website-previews/pr-previews/pr-659/ the link still does not work (404) |
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Sorry, please check again and please let me know the other examples |
@@ -104,7 +104,8 @@ const TheiaIDEDownloads = () => ( | |||
Help us make the Theia IDE even better, by <a href="https://github.com/eclipse-theia/theia/discussions">sharing your experience and suggestions</a>. | |||
The features found in the Eclipse Theia IDE are based on Eclipse Theia and the available extensions/plugins. For more details please see the <a href="https://github.com/eclipse-theia/theia">Eclipse Theia GitHub Repository</a>. The Eclipse Theia IDE only packages existing Eclipse Theia functionality and installers. If you believe there is a mistake in packaging, something needs to be added to the packaging or the installers do not work properly, please <a href="https://github.com/eclipse-theia/theia-blueprint/issues/new/choose">open an issue on GitHub</a> to let us know. | |||
<h1>Support</h1> | |||
Need help with Theia? To get support by the community go to the <a href="https://github.com/eclipse-theia/theia/discussions">Discussions at GitHub</a>. To get professional support for Theia see the <a href="./support/">support page</a>. | |||
Please refer to the <a href="/docs/user_getting_started/">Theia IDE Documentation</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one gives a 404
<Footer background={true} /> | ||
</Layout> | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is your IDE set to remove trailing newlines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the one after {true} ?
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
fixed #658
This PR is focussed on the Split only, it does not contain any further optimizations (which are now easier).
I am happy for any feedback, if possible in two categories: