[quick-pick] fix #7802: always accept items on type callback

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
eclipse-theia · May 13, 2020 · 09d90c4 · 09d90c4
1 parent 1b0b6d9
commit 09d90c4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/core/src/browser/quick-open/quick-pick-service-impl.ts b/packages/core/src/browser/quick-open/quick-pick-service-impl.ts
@@ -43,6 +43,7 @@ export class QuickPickServiceImpl implements QuickPickService {
     private readonly onDidChangeSelectionEmitter = new Emitter<(string | QuickPickValue<Object>)[]>();
     readonly onDidChangeSelection = this.onDidChangeSelectionEmitter.event;
 
+    // TODO when to release last elements?
     private elements: (string | QuickPickItem<Object>)[] = [];
 
     @postConstruct()
@@ -81,8 +82,8 @@ export class QuickPickServiceImpl implements QuickPickService {
                     if (this.elements !== elements) {
                         elements = this.elements;
                         items = this.toItems(elements, resolve);
-                        acceptor(items);
                     }
+                    acceptor(items);
                     if (savedValue !== value) {
                         this.onDidChangeValueEmitter.fire(value);
                         savedValue = value;