cli: use includeAllVersions when resolving packs (#12658)

The commit adds the `includeAllVersions` flag when querying for compatible plugins which are resolved for extension-packs, else the framework might fail early when a plugin is too new compared to our supported API range. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
eclipse-theia · Jun 29, 2023 · 1e1f9de · 1e1f9de
1 parent 4ccce3e
commit 1e1f9de
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dev-packages/cli/src/download-plugins.ts b/dev-packages/cli/src/download-plugins.ts
@@ -129,7 +129,7 @@ export default async function downloadPlugins(ovsxClient: OVSXClient, requestSer
             await parallelOrSequence(Array.from(ids, id => async () => {
                 try {
                     await rateLimiter.removeTokens(1);
-                    const { extensions } = await ovsxClient.query({ extensionId: id });
+                    const { extensions } = await ovsxClient.query({ extensionId: id, includeAllVersions: true });
                     const extension = apiFilter.getLatestCompatibleExtension(extensions);
                     const version = extension?.version;
                     const downloadUrl = extension?.files.download;

diff --git a/packages/vsx-registry/src/browser/vsx-extensions-model.ts b/packages/vsx-registry/src/browser/vsx-extensions-model.ts
@@ -315,7 +315,7 @@ export class VSXExtensionsModel {
             const client = await this.clientProvider();
             let data: VSXExtensionRaw | undefined;
             if (version === undefined) {
-                const { extensions } = await client.query({ extensionId: id });
+                const { extensions } = await client.query({ extensionId: id, includeAllVersions: true });
                 if (extensions?.length) {
                     data = this.vsxApiFilter.getLatestCompatibleExtension(extensions);
                 }

diff --git a/packages/vsx-registry/src/node/vsx-extension-resolver.ts b/packages/vsx-registry/src/node/vsx-extension-resolver.ts
@@ -54,7 +54,7 @@ export class VSXExtensionResolver implements PluginDeployerResolver {
             extension = extensions[0];
         } else {
             console.log(`[${id}]: trying to resolve latest version...`);
-            const { extensions } = await client.query({ extensionId: id });
+            const { extensions } = await client.query({ extensionId: id, includeAllVersions: true });
             extension = this.vsxApiFilter.getLatestCompatibleExtension(extensions);
         }
         if (!extension) {