9012-registerTerminalLinkProvider-stub: in order to facilitate vscode…

…-java-debug extension added registerTerminalLinkProvider stub which is invoked upon extension activation Signed-off-by: Dan Arad <dan.arad@sap.com>
eclipse-theia · Feb 14, 2021 · 33af8ac · 33af8ac
1 parent 8bd34f8
commit 33af8ac
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/packages/plugin-ext/src/plugin/plugin-context.ts b/packages/plugin-ext/src/plugin/plugin-context.ts
@@ -433,7 +433,7 @@ export function createAPIFactory(
                 return quickOpenExt.createInputBox(plugin);
             },
             registerTerminalLinkProvider(provider: theia.TerminalLinkProvider): void {
-                /* NOOP */
+                /* NOOP. To be implemented at later stage */
             },
             get activeColorTheme(): theia.ColorTheme {
                 return themingExt.activeColorTheme;

diff --git a/packages/plugin/src/theia.d.ts b/packages/plugin/src/theia.d.ts
@@ -2874,7 +2874,6 @@ declare module '@theia/plugin' {
     /**
      * Provides information on a line in a terminal in order to provide links for it.
      */
-    // copied from https://github.com/microsoft/vscode/blob/bd20a720fba05f87ddb53c11c6af66936fd88a55/src/vs/vscode.d.ts#L5563-L5576
     export interface TerminalLinkContext {
         /**
          * This is the text from the unwrapped line in the terminal.
@@ -2890,7 +2889,6 @@ declare module '@theia/plugin' {
     /**
      * A provider that enables detection and handling of links within terminals.
      */
-    // copied from https://github.com/microsoft/vscode/blob/bd20a720fba05f87ddb53c11c6af66936fd88a55/src/vs/vscode.d.ts#L5578-L5597
     export interface TerminalLinkProvider<T extends TerminalLink = TerminalLink> {
         /**
          * Provide terminal links for the given context. Note that this can be called multiple times
@@ -2912,7 +2910,6 @@ declare module '@theia/plugin' {
     /**
      * A link on a terminal line.
      */
-    // copied from https://github.com/microsoft/vscode/blob/bd20a720fba05f87ddb53c11c6af66936fd88a55/src/vs/vscode.d.ts#L5599-L5621
     export interface TerminalLink {
         /**
          * The start index of the link on [TerminalLinkContext.line](#TerminalLinkContext.line].
@@ -4034,7 +4031,6 @@ declare module '@theia/plugin' {
          * @param provider The provider that provides the terminal links.
          * @return Disposable that unregisters the provider.
          */
-        // copied from https://github.com/microsoft/vscode/blob/e790b931385d72cf5669fcefc51cdf65990efa5d/src/vs/vscode.d.ts#L8302-8307
         export function registerTerminalLinkProvider(provider: TerminalLinkProvider): void;
 
         /**