Skip to content

Commit

Permalink
[browser tests] re-enable find-replace suite
Browse files Browse the repository at this point in the history
Use an alternate .js file in this test: previously used webpack.config.js
was triggering a large number of TypeScript code actions at opening [1],
which may have contributed to the test's instability.

[1]: when setting the cursor at (0,0), a quick fix was available

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
  • Loading branch information
marcdumais-work committed Feb 10, 2023
1 parent 8fbddb8 commit 3e4b5c4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions examples/api-tests/src/find-replace.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Find and Replace', function () {
const shell = container.get(ApplicationShell);

const rootUri = workspaceService.tryGetRoots()[0].resource;
const fileUri = rootUri.resolve('webpack.config.js');
const fileUri = rootUri.resolve('../api-tests/test-ts-workspace/demo-file.ts');

const toTearDown = new DisposableCollection();

Expand Down Expand Up @@ -101,22 +101,22 @@ describe('Find and Replace', function () {
}

for (const command of [CommonCommands.FIND, CommonCommands.REPLACE]) {
it.skip(command.label + ' in the active editor', async function () {
it(command.label + ' in the active editor', async function () {
await navigatorContribution.openView({ activate: true });

await editorManager.open(fileUri, { mode: 'activate' });

await assertEditorFindReplace(command);
});

it.skip(command.label + ' in the active explorer without the current editor', async function () {
it(command.label + ' in the active explorer without the current editor', async function () {
await navigatorContribution.openView({ activate: true });

// should not throw
await commands.executeCommand(command.id);
});

it.skip(command.label + ' in the active explorer with the current editor', async function () {
it(command.label + ' in the active explorer with the current editor', async function () {
await editorManager.open(fileUri, { mode: 'activate' });

await navigatorContribution.openView({ activate: true });
Expand Down

0 comments on commit 3e4b5c4

Please sign in to comment.