Skip to content

Commit

Permalink
9012-updating-userstorageuri-scheme
Browse files Browse the repository at this point in the history
scheme was changed from 'user_storage' to 'user-storage' as '\_' is not a valid char in scheme (according to [RFC 3986](https://tools.ietf.org/html/rfc3986#page-17))

Signed-off-by: Dan Arad <dan.arad@sap.com>
  • Loading branch information
danarad05 committed Feb 14, 2021
1 parent 27e6ea7 commit 8d53a41
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# Change Log
## v1.11.0 - 2021

<a name="breaking_changes_1.11.0">[Breaking Changes:](#breaking_changes_1.11.0)</a>

<a name="1.11.0_user-storage_scheme_updated"></a>

- [[user-storage]](#1.11.0_user-storage_scheme_updated) `UserStorageUri` scheme was changed from 'user_storage' to 'user-storage' as '\_' is not a valid char in scheme (according to [RFC 3986](https://tools.ietf.org/html/rfc3986#page-17)) [#9049](https://github.com/eclipse-theia/theia/pull/9049)


## v1.10.0 - 1/28/2021

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { PreferenceConfigurations } from '@theia/core/lib/browser/preferences/pr
import { PreferenceScope } from '@theia/core/lib/browser';

const PREFERENCE_URI_PREFIX = 'vscode://schemas/settings/';
const USER_STORAGE_PREFIX = 'user_storage:/';
const USER_STORAGE_PREFIX = 'user-storage:/';

@injectable()
export class PreferencesJsonSchemaContribution implements JsonSchemaContribution {
Expand Down
2 changes: 1 addition & 1 deletion packages/userstorage/src/browser/user-storage-uri.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@

import URI from '@theia/core/lib/common/uri';

export const UserStorageUri = new URI('user_storage:/user');
export const UserStorageUri = new URI('user-storage:/user');
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('WorkspaceUriLabelProviderContribution class', () => {

describe('canHandle()', () => {
it('should return 0 if the passed in argument is not a FileStat or URI with the "file" scheme', () => {
expect(labelProvider.canHandle(new URI('user_storage:settings.json'))).eq(0);
expect(labelProvider.canHandle(new URI('user-storage:settings.json'))).eq(0);
expect(labelProvider.canHandle({ uri: 'file:///home/settings.json' })).eq(0);
});

Expand Down

0 comments on commit 8d53a41

Please sign in to comment.