More review feedback

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
eclipse-theia · Apr 12, 2023 · 8e0142a · 8e0142a
1 parent 477d033
commit 8e0142a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@
 ## History
 
 - [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)
+## v1.37.0 0 -
+
+<a name="breaking_changes_1.37.0">[Breaking Changes:](#breaking_changes_1.37.0)</a>
+- [core] Inject core preference into `DockPanelRenderer` constructor [12360](https://github.com/eclipse-theia/theia/pull/12360)
+- [core] Introduced `ScrollableTabBar.updateTabs()` to fully render tabs [12360](https://github.com/eclipse-theia/theia/pull/12360)
 
 ## v1.36.0 0 - 03/30/2023
 

diff --git a/packages/core/src/browser/core-preferences.ts b/packages/core/src/browser/core-preferences.ts
@@ -236,19 +236,19 @@ export const corePreferenceSchema: PreferenceSchema = {
         'workbench.tab.shrinkToFit.enabled': {
             type: 'boolean',
             default: false,
-            description: nls.localize('theia/core/tabShrinkToFit', 'Shrink tabs to fit available space')
+            description: nls.localize('theia/core/tabShrinkToFit', 'Shrink tabs to fit available space.')
         },
         'workbench.tab.shrinkToFit.minimumSize': {
             type: 'number',
             default: 50,
             minimum: 10,
-            description: nls.localize('theia/core/tabMinimumSize', 'Minimum size for tabs')
+            description: nls.localize('theia/core/tabMinimumSize', 'Specifies the minimum size for tabs.')
         },
         'workbench.tab.shrinkToFit.defaultSize': {
             type: 'number',
             default: 200,
             minimum: 10,
-            description: nls.localize('theia/core/tabDefaultSize', 'Default size for tabs')
+            description: nls.localize('theia/core/tabDefaultSize', 'Specifies the default size for tabs.')
         }
     }
 };

diff --git a/packages/core/src/browser/style/tabs.css b/packages/core/src/browser/style/tabs.css
@@ -415,7 +415,7 @@
   flex: 1;
 }
 
-.p-TabBar-tab.p-mod-closable:hover .theia-tab-icon-label,
-.p-TabBar-tab.p-mod-current .theia-tab-icon-label {
+.p-TabBar[data-orientation='horizontal'] .p-TabBar-tab.p-mod-closable:hover .theia-tab-icon-label,
+.p-TabBar[data-orientation='horizontal'] .p-TabBar-tab.p-mod-current .theia-tab-icon-label {
   overflow: hidden;
 }