Skip to content

Commit

Permalink
about: dialog does not display correctly when re-opened
Browse files Browse the repository at this point in the history
Fixes: #7129
The help dialog was not rendering the list of extensions, hence functionality was added to display the list even after it being closed once.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
  • Loading branch information
Muhammad Anas Shahid committed Feb 12, 2020
1 parent 46a2d51 commit d3b9e42
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/core/src/browser/about-dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { inject, injectable, postConstruct } from 'inversify';
import { DialogProps } from './dialogs';
import { ReactDialog } from './dialogs/react-dialog';
import { ApplicationServer, ApplicationInfo, ExtensionInfo } from '../common/application-protocol';
import { Message } from './widgets/widget';

export const ABOUT_CONTENT_CLASS = 'theia-aboutDialog';
export const ABOUT_EXTENSIONS_CLASS = 'theia-aboutExtensions';
Expand Down Expand Up @@ -79,5 +80,10 @@ export class AboutDialog extends ReactDialog<void> {
</div>;
}

protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
this.update();
}

get value(): undefined { return undefined; }
}

0 comments on commit d3b9e42

Please sign in to comment.