GH-815: Fixed process ID generation. Replaced type with interface.

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
eclipse-theia · Nov 27, 2017 · e274c62 · e274c62
1 parent 8fe8ecb
commit e274c62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/process/src/node/process-manager.ts b/packages/process/src/node/process-manager.ts
@@ -22,8 +22,10 @@ export class ProcessManager {
     }
 
     register(process: Process): number {
-        this.processes.set(++this.id, process);
-        return this.id;
+        const id = this.id;
+        this.processes.set(id, process);
+        this.id++;
+        return id;
     }
 
     get(id: number): Process | undefined {

diff --git a/packages/process/src/node/terminal-process.ts b/packages/process/src/node/terminal-process.ts
@@ -21,7 +21,9 @@ export interface TerminalProcessOptions {
 }
 
 export const TerminalProcessFactory = Symbol("TerminalProcessFactory");
-export type TerminalProcessFactory = (options: TerminalProcessOptions) => TerminalProcess;
+export interface TerminalProcessFactory {
+    (options: TerminalProcessOptions): TerminalProcess;
+}
 
 /* Use this instead of the node-pty stream, since the node-pty stream is already resumed.  */
 class ReadableTerminalStream extends stream.Readable {