Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Type ConfigurationScope #10004

Closed
Tracked by #9863
tsmaeder opened this issue Aug 31, 2021 · 3 comments · Fixed by #11393
Closed
Tracked by #9863

Introduce Type ConfigurationScope #10004

tsmaeder opened this issue Aug 31, 2021 · 3 comments · Fixed by #11393
Assignees
@colin-grant-work
Labels
preferences issues related to preferences vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

Add the ConfigurationScope type and use it in vscode.workspace.getConfiguration(...) and ConfigurationChangedEvent#affectsConfiguration().
@tsmaeder tsmaeder added preferences issues related to preferences vscode issues related to VSCode compatibility labels Aug 31, 2021
@tsmaeder tsmaeder mentioned this issue Aug 31, 2021
Closed
48 tasks
@colin-grant-work colin-grant-work self-assigned this Mar 31, 2022
@colin-grant-work
Copy link
Contributor

I'll take this one, and improve our affectsConfiguration implementation, as well.

@colin-grant-work colin-grant-work mentioned this issue Jul 7, 2022
Merged
1 task
@JonasHelming
Copy link
Contributor

@colin-grant-work Is this still on your radar?

@colin-grant-work
Copy link
Contributor

@JonasHelming, it is fixed by #11393, which is just waiting on reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-grant-work colin-grant-work

Labels
preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Plugin Preference Access colin-grant-work/theia
3 participants
@JonasHelming @tsmaeder @colin-grant-work