Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Gap theia master vs. VS Code 1.55.2 #9863

Closed
48 tasks done
Tracked by #11520
tsmaeder opened this issue Aug 9, 2021 · 12 comments · Fixed by #11823
Closed
48 tasks done
Tracked by #11520

API Gap theia master vs. VS Code 1.55.2 #9863

tsmaeder opened this issue Aug 9, 2021 · 12 comments · Fixed by #11823
Labels
epic epic issues consisting of multiple smaller issues vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 9, 2021 •
edited by JonasHelming
Loading

This bug tracks the differences between current master Theia VS Code API and VS Code 1.55.2
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility epic epic issues consisting of multiple smaller issues labels Aug 9, 2021
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Aug 9, 2021 •
edited by msujew
Loading

Types:

AccessibilityInformation missing #9965
AuthenticationProvider in theia-proposed.d.ts
AuthenticationProviderAuthenticationSessionsChangeEvent in theia-proposed.d.ts
CallHierarchyItem

CancellationError missing #9988
CodeAction

CodeActionKind

CodeActionProvider no type parameter T

CodeActionProviderMetadata

CommentThread

CompletionItemKind

ConfigurationScope missing #10004
CustomDocumentOpenContext

DebugAdapter missing #10006
DebugAdapterDescriptor missing types DebugAdapterNampedPipeServer and DebugAdapterInlineImplementation #10006
DebugAdapterNampedPipeServer missing #10006
DebugAdapterInlineImplementation missing #10006
DebugConfigurationProviderTriggerKind missing #10008
DebugConsoleMode missing #10009
DebugProtocolBreakpoint missing #10011
DebugProtocolMessage missing #10006
DebugProtocolSource missing #10011
DebugSession

DebugSessionOptions seems to be false positive: interface is present and looks the same.
Declaration missing #10024
DiagnosticTag seems to be a false positive
DocumentSelector

DocumentSymbolProviderMetadata missing #10026
EvaluatableExpression missing #10027
EvaluatableExpressionProvider missing #10027
Extension

ExtensionContext

ExtensionKind missing
ExtensionMode missing #10201
ExtensionTerminaOptions => PseudoTerminalOptions
FileSystem

  • isWritableFileSystem missing

FoldingRangeProvider

  • onDidChangeFoldingRanges missing

InlineValue missing #10028
InlineValueContext missing #10028
InlineValueEvaluatableExpression missing #10028
InlineValuesProvider missing #10028
InlineValueText missing #10028
InlineValueVariableLookup missing #10028
InputBoxOptions

LanguageConfiguration

LinkedEditingRangeProvider #10200
LinkedEditingRanges #10200
LocationLink missing #10024
MarkdownString

  • constructor missing supportThemeIcons parameter
  • supportThemeIcons missing

OnEnterRule

  • previousLineText

Pseudoterminal

  • onDidChangeName

QuickPickItem

  • alwaysShow false positive

QuickPickOptions

  • title missing

Run Options missing
SignatureInformation

  • activeParameter missing

SnippetParameter

  • appendChoice missing

SourcControlInputBox

  • visible missing

StatusBarItem

Task

  • detail missing
  • runOptions missing

TaskPresentationOptions

  • clear missing

Terminal

  • creationOptions missing
  • exitStatus missing

TerminalExitStatus missing
TerminalOptions

  • strictEnv
  • hideFromUser
  • message

TextEditor

  • show missing
  • hide missing

ThemeIcon

  • color missing
  • constructor: missing color parameter

Thenable missing
TreeDataProvider

  • resolveTreeItem

TreeItem

TreeItemLabel

  • highlights missing

TreeView

TreeViewOptions

  • canSelectMany

WebviewView missing #8740
WebviewViewProvider missing #8740
WebviewViewResolveContext missing #8740

namespaces:

env

  • isNewAppInstall missing
  • isTelemetryEnabled missing
  • onDidChangeTelemetryEnabled
  • remoteName

window

workspace

  • getConfiguration parameter scope: uri => ConfigurationScope

languages

debug

extensions

  • onDidChange modifier let => const

authentication

  • registerAuthenticationProvider => changed parameters

@SriniBlrRaman
Copy link

Can you share the plan for addressing the API gap. Thanks.

@tsmaeder
Copy link
Contributor Author

@SriniBlrRaman Step 1: Create issues to address 2. Get community members to sign commit resources to fixing them.

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Aug 26, 2021 •
edited
Loading

@tsmaeder, what's the status of this project, apparently connected with Che? Is it up-to-date, and kept so automatically? If so, it might be a useful reference for this issue, and we could just rename this issue 'VSCode API Gap' and pin it (if GitHub allows that), rather than creating issues tied to particular VSCode versions? Or if we can't pin it, maybe make it a 'Project' (I don't think we have any of those yet...) so that it doesn't just sink down the issue list gradually.

Might also be nice to be able to filter the list on that page to see only unimplemented API features.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Aug 27, 2021 •
edited
Loading

@colin-grant-work I'm working on moving the code to the theia org. The problem with just pointing over there is that it's not actionable: we need to group the diffs from the API into coherent work items the community can sign up for and that can sized. My long term goal would be to move from an "ad-hoc" implementation of whatever we need right now to a release-based system where we can state "we support VS Code API v x.y.z".

See also https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23652

@msujew msujew mentioned this issue Sep 21, 2021
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Sep 23, 2021
Merged
1 task
@WaynePhillipsEA WaynePhillipsEA mentioned this issue Oct 4, 2021
Closed
@hzhang1902
Copy link

Really need debug.stopDebugging. It's strange to have startDebugging but not stop aye?

lucas-koehler added a commit to lucas-koehler/vscode-theia-comparator that referenced this issue Jan 18, 2022
@lucas-koehler
Add initial issue links
2bcdafb 
* Add initial issue links as notes based on eclipse-theia/theia#9863.
* Tweak generated html code to open clicked links in a new tab/window and improve link color for readability

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to lucas-koehler/vscode-theia-comparator that referenced this issue Jan 18, 2022
@lucas-koehler
Add initial issue links
cfbb698 
* Add initial issue links as notes based on eclipse-theia/theia#9863.
* Tweak generated html code to open clicked links in a new tab/window and improve link color for readability

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
@lucas-koehler lucas-koehler mentioned this issue Jan 18, 2022
Merged
JonasHelming pushed a commit to eclipse-theia/vscode-theia-comparator that referenced this issue Jan 24, 2022
@lucas-koehler
Note support and additional filtered report (#9)
9c38d6d 
* Improve HTML generator code

* Refactor the HTML generator to reuse common code and improve code readability.
* Fix typo in HTML generator
* Fix indentation and missing semicolons

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>

* Add additional notes to report

Add a parser for additional information parsed from a YAML file.
For now, only a note can be specified.

Notes can be specified for any row in the report via a YAML file.
These are read during generation and added in a new column Note.

Additional minor fixes:
* No longer allow unused variables in tsconfig.json
* Exit with error code 1 in case an error occurs

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>

* Additional filtered report only containing unsupported API

Extend the generator to generate a second output file filtered-status.html that only contains unsupported API.

* Extend comparator with a removeSupported method
* Generate second report in index.ts
* Extend README with second badge and update example output

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>

* Add initial issue links

* Add initial issue links as notes based on eclipse-theia/theia#9863.
* Tweak generated html code to open clicked links in a new tab/window and improve link color for readability

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
@ndoschek
Copy link
Contributor

window

  • createStatusBarItem: missing override with id parameter

Fixed via #10754 (issue: #10696)

@JonasHelming JonasHelming mentioned this issue Mar 21, 2022
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Mar 21, 2022
Merged
@lucas-koehler
Copy link
Contributor

StatusBarItem

  • id missing
  • name missing
  • backgroundColor missing

I added #11019 for these.

@colin-grant-work
Copy link
Contributor

TextDocumentChangeReason, LanguageStatusItem

I'm working on these as part of #10819.

@planger
Copy link
Contributor

planger commented May 12, 2022

@tsmaeder I've added a couple of issues for the remaining 1.55.2 API gap and updated the notes of the vscode-theia-comparator accordingly for existing issues and the new ones I created (see PR#24).

In case you would like to update your list above too, I guess it is easiest to go through the diff of the PR.

As far as I checked all missing interfaces, there should now be an issue for everything that's still missing.

Thanks!

@tsmaeder
Copy link
Contributor Author

Awesome, thx @planger

@msujew msujew mentioned this issue Jul 12, 2022
Closed
@msujew msujew mentioned this issue Aug 1, 2022
Closed
@planger planger mentioned this issue Aug 3, 2022
Closed
19 tasks
@planger
Copy link
Contributor

planger commented Aug 3, 2022

@tsmaeder I believe there is actually another one for 1.55.2: #11521

@vince-fugnitto vince-fugnitto mentioned this issue Nov 2, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic epic issues consisting of multiple smaller issues vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugin: update default api version to 1.55.2 eclipse-theia/theia
7 participants
@planger @SriniBlrRaman @lucas-koehler @tsmaeder @hzhang1902 @ndoschek @colin-grant-work