Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support optional property OnEnterRule#previousLineText #11131

Closed
Tracked by #9863
planger opened this issue May 11, 2022 · 2 comments · Fixed by #11225
Closed
Tracked by #9863

[vscode] Support optional property OnEnterRule#previousLineText #11131

planger opened this issue May 11, 2022 · 2 comments · Fixed by #11225
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 11, 2022

Feature Description:

Allow plugins contributing a LanguageConfiguration to specify OnEnterRules with an optional previousLineText property value, see https://code.visualstudio.com/api/references/vscode-api#OnEnterRule
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 11, 2022
@JonasHelming JonasHelming mentioned this issue May 13, 2022
Closed
48 tasks
@planger
Copy link
Contributor Author

planger commented May 25, 2022

Blocked by #11202

planger added a commit to eclipsesource/theia that referenced this issue May 30, 2022
@planger
[WIP] Support OnEnterRule#previousLineText
4b1ca54 
eclipse-theia#11131

Contributed on behalf of STMicroelectronics

Change-Id: Ieff708dedac5bcb9c387eccf6c58dffabb2b455f
@planger
Copy link
Contributor Author

planger commented May 30, 2022

I started looking into this issue.

planger added a commit to eclipsesource/theia that referenced this issue May 31, 2022
@planger
vscode: Support OnEnterRule#previousLineText
5d60416 
Fixes eclipse-theia#11131

Contributed on behalf of STMicroelectronics

Change-Id: Ieff708dedac5bcb9c387eccf6c58dffabb2b455f
Signed-off-by: Philip Langer <planger@eclipsesource.com>
@planger planger mentioned this issue May 31, 2022
Merged
1 task
martin-fleck-at pushed a commit that referenced this issue Jun 7, 2022
@planger @martin-fleck-at
vscode: Support OnEnterRule#previousLineText
cc06ad8 
Fixes #11131

Contributed on behalf of STMicroelectronics

Change-Id: Ieff708dedac5bcb9c387eccf6c58dffabb2b455f
Signed-off-by: Philip Langer <planger@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
2 participants
@planger @vince-fugnitto