Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support optional property ThemeIcon#color #11128

Closed
Tracked by #9863
planger opened this issue May 11, 2022 · 1 comment · Fixed by #11243
Closed
Tracked by #9863

[vscode] Support optional property ThemeIcon#color #11128

planger opened this issue May 11, 2022 · 1 comment · Fixed by #11243
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 11, 2022

Feature Description:

Support plugins referring to a ThemeIcon with a specific ThemeColor via constructor or property color of a ThemeIcon, see https://code.visualstudio.com/api/references/vscode-api#ThemeIcon

@lucas-koehler
Copy link
Contributor

I'll investigate this

lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 2, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes eclipse-theia#11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 2, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes eclipse-theia#11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 2, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes eclipse-theia#11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 2, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes eclipse-theia#11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 2, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes eclipse-theia#11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
JonasHelming pushed a commit that referenced this issue Jun 9, 2022
* Add optional color property to ThemeIcon
* Hand over the ThemeIcon instead of just its id from ext to main
* Apply the color in the `PluginTree`
* Adapt `TreeViewNode.is` to also recognize sub types such as `CompositeTreeViewNode`

Fixes #11128

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants