Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extension#extensionKind #10029

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 6 comments
Closed
Tracked by #9863

Add Extension#extensionKind #10029

tsmaeder opened this issue Sep 1, 2021 · 6 comments
Labels
vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021

Feature Description:

The extensionKind field relates to VS Code remote development: https://code.visualstudio.com/docs/remote/faq as such it's not related to frontend/backend in Theia.
See https://code.visualstudio.com/docs/remote/faq
Having this feature is not immediately usefule in plain Theia, but might be of use, for example in Eclipse Che

@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Sep 1, 2021
@thegecko
Copy link
Member

thegecko commented Mar 1, 2022

I believe extensionKind is used to determine where to run an extension based on capabilities of the extension, whether running in the browser or on the desktop and the extension hosts available:

https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location

The loading decision for this has been implemented as part of the web extension support; #10721:

https://github.com/eclipse-theia/theia/pull/10721/files#diff-c1883dca6f565aacd7c02f8b557fb49d48f99d0828cde8878e06d260a7ffcc07R39

Is there anything else required?

@vince-fugnitto
Copy link
Member

Is there anything else required?

I believe the idea to add it as part of theia.d.ts since it is currently marked as unsupported:

image

@sgraband
Copy link
Contributor

The loading decision for this has been implemented as part of the web extension support; #10721:

https://github.com/eclipse-theia/theia/pull/10721/files#diff-c1883dca6f565aacd7c02f8b557fb49d48f99d0828cde8878e06d260a7ffcc07R39

If i undertand the change correctly the UI ExtensionKind is mapped to the frontend PluginType and Workspace to backend accordingly?

If this is the case, then there isn't actually something missing in the theia.d.ts. Basically we are just missing the translation from extension to plugin for the extensionUri and the extensionKind. It is already existing for the extensionPath here.

I will gladly provide a fix, if my understanding of the mapping is indeed correct. Can either of you confirm this? @vince-fugnitto or @thegecko

@thegecko
Copy link
Member

It's been a while, but my research into this culminated in the comments you see in the link above. I also did some work around the correct exposure of extensionUri in plugins: #10747

@sgraband
Copy link
Contributor

I opened a PR in the comparator that solves the issue, that the extensionKind (and the extensionURI) are shown as unsupported in the overview.

@sgraband
Copy link
Contributor

The PR has been merged and the ExtensionKind is now showing as supported see here. Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

5 participants