Add missing mapping between extension and plugin #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand `extensionUri`, `extensionKind` and the enum `ExtensionKind` were flagged as missing on the Theia side. This is due to the fact, that the names are different. For the `extensionPath` there was already a mapping in the comparator. This change also adds them for the two fields and the enum. Contributed on behalf of STMicroelectronics
lucas-koehler
approved these changes
Jun 29, 2022
JonasHelming
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand
extensionUri,extensionKindand the enumExtensionKindwere flagged as missing on the Theia side.
This is due to the fact, that the names are different.
For the
extensionPaththere was already a mapping in the comparator.This change also adds them for the two fields and the enum.
Contributed on behalf of STMicroelectronics