Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Implement window.registerTerminalLinkProvider #11521

Closed
Tracked by #9863
planger opened this issue Aug 3, 2022 · 1 comment · Fixed by #11552
Closed
Tracked by #9863

[vscode] Implement window.registerTerminalLinkProvider #11521

planger opened this issue Aug 3, 2022 · 1 comment · Fixed by #11552
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented Aug 3, 2022 •
edited
Loading

The API exists, but it doesn't seem to be implemented actually:

theia/packages/plugin-ext/src/plugin/plugin-context.ts

Lines 503 to 505 in 7e177f9

registerTerminalLinkProvider(provider: theia.TerminalLinkProvider): void {
/* NOOP. To be implemented at later stage */
},

The type TerminalLink already exists, however it is a class with constructor in VS Code, see #11507
@planger planger mentioned this issue Aug 3, 2022
Closed
48 tasks
planger added a commit to eclipsesource/theia that referenced this issue Aug 3, 2022
@planger
vscode: Make TerminalLink compatible to VS Code 1.64.2
0f56515 
In the course of fixing this, I discovered eclipse-theia#11521.
Turning `TerminalLink` into a class with a constructor will help anyway,
and is effective once eclipse-theia#11521 is fixed.

Fixes eclipse-theia#11507

Contributed on behalf of STMicroelectronics.

Change-Id: I7aa945445cbbe05f09746d7824b3153fec6b38f2
Signed-off-by: Philip Langer <planger@eclipsesource.com>
@paul-marechal paul-marechal added the vscode issues related to VSCode compatibility label Aug 3, 2022
@planger planger mentioned this issue Aug 3, 2022
Closed
1 task
planger added a commit to eclipsesource/theia that referenced this issue Aug 3, 2022
@planger
vscode: Make TerminalLink compatible to VSCode
7beb5ea 
Replaces the out-dated definition of the TerminalLink interface with the current class that also provides a constructor.

In the course of fixing this, I discovered eclipse-theia#11521.
So it looks like Theia doesn't support registering TerminalLinkProvider
at the moment. Anyway, making TerminalLink compatible to VS Code
will help anyway, but only really gets effective once eclipse-theia#11521 is fixed.

Fixes eclipse-theia#11507
Contributed on behalf of STMicroelectronics.

Change-Id: If183c73b8152770c4c9062355f92143f7e201e53
Signed-off-by: Philip Langer <planger@eclipsesource.com>
@planger
Copy link
Contributor Author

planger commented Aug 5, 2022

I'll look into providing the actual functionality for window.registerTerminalLinkProvider. Also, in a first glance, I think it makes sense to harmonize this implementation with AbstractCmdClickTerminalContribution and try to get rid of the usage of the deprecated xterm registerLinkMatcher API.

planger added a commit to eclipsesource/theia that referenced this issue Aug 10, 2022
@planger
terminal: Support VS Code Terminal Link Providers
53cbe4a 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
@planger planger mentioned this issue Aug 10, 2022
Merged
1 task
planger added a commit to eclipsesource/theia that referenced this issue Aug 10, 2022
@planger
terminal: Support VS Code Terminal Link Providers
339ebcd 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
planger added a commit to eclipsesource/theia that referenced this issue Aug 12, 2022
@planger
terminal: Support VS Code Terminal Link Providers
5f11e46 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
planger added a commit to eclipsesource/theia that referenced this issue Sep 7, 2022
@planger
terminal: Support VS Code Terminal Link Providers
a7992c4 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507
Fixes eclipse-theia#11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
planger added a commit to eclipsesource/theia that referenced this issue Sep 28, 2022
@planger
terminal: Support VS Code Terminal Link Providers
b23a19a 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507
Fixes eclipse-theia#11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
planger added a commit to eclipsesource/theia that referenced this issue Sep 29, 2022
@planger
terminal: Support VS Code Terminal Link Providers
9baa004 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507
Fixes eclipse-theia#11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
planger added a commit to eclipsesource/theia that referenced this issue Oct 12, 2022
@planger
terminal: Support VS Code Terminal Link Providers
bb17f8e 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes eclipse-theia#11521
Fixes eclipse-theia#11507
Fixes eclipse-theia#11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
JonasHelming pushed a commit that referenced this issue Oct 12, 2022
@planger
terminal: Support VS Code Terminal Link Providers (#11552)
cac96ae 
* Implement the previously mocked support for Terminal Link Providers
* Introduce Theia contribution point for adding link providers
* Migrate existing link matchers to this new contribution point
* Get rid of the usage of the deprecated xterm.registerLinkMatcher API
* Fix UI bug where the link hover doesn't show up
  This happened when the mouse is above the hover as it gets
  visible, leading to xterm canceling the hover right away, because the
  mouse "seemingly" left the link.
  This has been fixed by preventing to hide it   if the mouse left the
  link but is above the hover.
* Turn the hover text into a clickable link

Contributed on behalf of STMicroelectronics.

Fixes #11521
Fixes #11507
Fixes #11491

Change-Id: I01f907d778f4a5f0588202ea28c4c82252ab75dc
Signed-off-by: Philip Langer <planger@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

terminal: Support VS Code Terminal Link Providers eclipsesource/theia
2 participants
@planger @paul-marechal