Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Add support for WebviewViewResolveContext #11149

Closed
Tracked by #9863
planger opened this issue May 12, 2022 · 0 comments · Fixed by #11216
Closed
Tracked by #9863

[vscode] Add support for WebviewViewResolveContext #11149

planger opened this issue May 12, 2022 · 0 comments · Fixed by #11216
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 12, 2022 •
edited
Loading

Feature Description:

Add WebviewViewResolveContext and its functionality in the context of resolveWebviewView(webviewView: WebviewView, context: WebviewViewResolveContext, token: CancellationToken).

See also #8740 which added the registerWebviewViewProvider API
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 12, 2022
@vince-fugnitto vince-fugnitto mentioned this issue May 30, 2022
Merged
1 task
sgraband added a commit to eclipsesource/theia that referenced this issue Jun 1, 2022
@sgraband
Move WebviewViewResolveContext to root namespace
ff3597a 
The WebviewViewResolveContext was previously in the window namespace.
Removed it in the window namespace and added it to root namespace.

Fixes eclipse-theia#11149.

Contributed on behalf of STMicroelectronics.
JonasHelming pushed a commit that referenced this issue Jun 2, 2022
@sgraband
Move WebviewViewResolveContext to root namespace (#11216)
a6f438c 
The WebviewViewResolveContext was previously in the window namespace.
Removed it in the window namespace and added it to root namespace.

Fixes #11149.

Contributed on behalf of STMicroelectronics.
@JonasHelming JonasHelming mentioned this issue Jun 2, 2022
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move WebviewViewResolveContext to root namespace eclipsesource/theia
2 participants
@planger @vince-fugnitto