Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support Task#runOptions #11132

Closed
Tracked by #9863
planger opened this issue May 11, 2022 · 3 comments · Fixed by #11759
Closed
Tracked by #9863

[vscode] Support Task#runOptions #11132

planger opened this issue May 11, 2022 · 3 comments · Fixed by #11759
Assignees
@sgraband
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 11, 2022

Feature Description:

Support specifying RunOptions for a Task. Both is missing, the type RunOptions and support for the property Task#runOptions.
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 11, 2022
@JonasHelming JonasHelming mentioned this issue May 13, 2022
Closed
48 tasks
@sgraband
Copy link
Contributor

I will take a look!

@vince-fugnitto
Copy link
Member

@sgraband do you have any update on the API?

@sgraband
Copy link
Contributor

@vince-fugnitto I already added the API, but then i realized that the options passed via the API will have no effect, as they are currently not supported, so i wanted to add support for the reevaluateOnRerun option. But this requires some reworking of what information about the last tasks we store.

I am planning to finish this in the beginning of October, if this is fine?

sgraband added a commit to eclipsesource/theia that referenced this issue Oct 12, 2022
@sgraband
Add task#runOptions to API.
a627f16 
Additionally added functionality to support `reevaluateOnRerun`.
If this flag is set to false no variables will be resolved again.
Therefore lastTask can now be re-triggered without resolving all variables.
For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves eclipse-theia#11132
This was referenced Oct 12, 2022
Closed
Merged
sgraband added a commit to eclipsesource/theia that referenced this issue Oct 12, 2022
@sgraband
Add task#runOptions to API.
03fd853 
Additionally added functionality to support `reevaluateOnRerun`.
If this flag is set to false no variables will be resolved again.
Therefore lastTask can now be re-triggered without resolving all variables.
For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves eclipse-theia#11132
sgraband added a commit to eclipsesource/theia that referenced this issue Oct 17, 2022
@sgraband
Add task#runOptions to API.
b3082b5 
Additionally added functionality to support `reevaluateOnRerun`.
If this flag is set to false no variables will be resolved again.
Therefore lastTask can now be re-triggered without resolving all variables.
For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves eclipse-theia#11132
sgraband added a commit to eclipsesource/theia that referenced this issue Nov 2, 2022
@sgraband
Add task#runOptions to API.
c712f75 
Additionally added functionality to support `reevaluateOnRerun`.
If this flag is set to false no variables will be resolved again.
Therefore lastTask can now be re-triggered without resolving all variables.
For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves eclipse-theia#11132
colin-grant-work pushed a commit that referenced this issue Nov 2, 2022
@sgraband
Add task#runOptions to API. (#11759)
385860d 
* Add `task#runOptions` to API.

Additionally added functionality to support `reevaluateOnRerun`.
If this flag is set to false no variables will be resolved again.
Therefore lastTask can now be re-triggered without resolving all variables.
For this the lastTask object was updated to contain all resolved information.

Contributed on behalf of STMicroelectronics

Resolves #11132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgraband sgraband

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add task#runOptions to API. eclipsesource/theia
3 participants
@planger @vince-fugnitto @sgraband