Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support TextEditor#show() and TextEditor#hide() #11146

Closed
Tracked by #9863
planger opened this issue May 12, 2022 · 1 comment · Fixed by #11168
Closed
Tracked by #9863

[vscode] Support TextEditor#show() and TextEditor#hide() #11146

planger opened this issue May 12, 2022 · 1 comment · Fixed by #11168
Assignees
@jfaltermeier
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 12, 2022

Feature Description:

Add support for showing and hiding text editors with show(column?: ViewColumn) and hide(), see https://code.visualstudio.com/api/references/vscode-api#TerminalOptions.
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 12, 2022
@JonasHelming JonasHelming mentioned this issue May 13, 2022
Closed
48 tasks
@jfaltermeier
Copy link
Contributor

I will have a look at this

@jfaltermeier jfaltermeier self-assigned this May 16, 2022
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 16, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
204b55d 
…a#11146

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 17, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
05cf1ca 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 17, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
a52d3bf 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 17, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
0ea2088 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
@JonasHelming JonasHelming mentioned this issue May 17, 2022
Merged
1 task
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 18, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
44dab0c 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue May 19, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
fda5937 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue Jun 7, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
73950d5 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit to eclipsesource/theia that referenced this issue Jun 14, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() eclipse-thei…
22083c3 
…a#11146

* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
jfaltermeier added a commit that referenced this issue Jun 14, 2022
@jfaltermeier
[vscode] Support TextEditor#show() and TextEditor#hide() #11146
b9a94e5 
* extends theia.d.ts accordingly
* adapt editor-manager to handle split editor open-request with missing
counter option by computing the counter
* add show/hide to TextEditorsMain interface

Signed-off-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>

Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfaltermeier jfaltermeier

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] Support TextEditor#show() and TextEditor#hide() #11146 eclipsesource/theia
3 participants
@planger @jfaltermeier @vince-fugnitto