Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theia] Need a clear distinction between the navigator and the editor #1057

Closed
lmcbout opened this issue Jan 15, 2018 · 9 comments
Closed

[theia] Need a clear distinction between the navigator and the editor #1057

lmcbout opened this issue Jan 15, 2018 · 9 comments
Labels
design issues related to design

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Jan 15, 2018

We need a clear distinction between the navigator and the editor. Both use the same background colour. If you look at the sidebar menu, the background is another colour and the user can see a proper distinction between the side menu-bar and the navigator or
peek 2018-01-15 10-14 nodistinction betweennavigator-editor
editor. The distinction is not there between the navigator and the editor

@svenefftinge
Copy link
Contributor

Just so you are aware, the fact that the separator line is not always shown is because you are not running on the default zoom-level.

@svenefftinge
Copy link
Contributor

We are going to make layouts quite flexible, so that you can move any widget anywhere. Different backgrounds will therefore not work.

@lmcbout
Copy link
Contributor Author

lmcbout commented Jan 16, 2018

I don't know exactly what is the default zoom-level, but there is more than just one window size when the line separator is not shown. Here another video when the separator is not visible , with
peek 2018-01-16 nodistinction betweennavigator-editorzoom
a different size:

@hexa00
Copy link

hexa00 commented Jan 16, 2018

@lmcbout you can use Ctrl-0 to get to the default zoom level (that's Ctrl-zero)

@epatpol
Copy link
Contributor

epatpol commented Jan 17, 2018

A different tone of "gray" or the editor color would help also, I think it's like that in Atom and vscode afaik.

@lmcbout
Copy link
Contributor Author

lmcbout commented Jan 18, 2018

Using a different background make a good difference. Theia with three editors and navigator and the outline view,
1- as it is currently:
theiabeforeissue_1057

2- only change the editor background a with "theia-layout-color2"
theiaonlyeditorissue1057

3- change the editor and the margin beside the editor with "theia-layout-color2"
theiaafter marginandeditorissue1057

@svenefftinge
Copy link
Contributor

Besides that it doesn't look good (IMHO), it won't solve the issue as it only increases contrast between editors and non-editors (see #1057 (comment))

@epatpol
Copy link
Contributor

epatpol commented Jan 18, 2018

#2 and #3 increases the contrast which makes it easier to see the limits of the editor and the panel on the side. However it greatly decreases editor usability in itself with the contrast being wrong with the text. I agree with above and think we should wait until flexible layout is in and see if we can improve something then.

@svenefftinge svenefftinge added the design issues related to design label Jan 19, 2018
@vince-fugnitto
Copy link
Member

there is a distinction between editors/widgets with the added border

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issues related to design
Projects
None yet
Development

No branches or pull requests

5 participants