Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: Open dialogs are not modal #10768

Closed
AlexandraBuzila opened this issue Feb 17, 2022 · 1 comment
Closed

electron: Open dialogs are not modal #10768

AlexandraBuzila opened this issue Feb 17, 2022 · 1 comment
Labels
electron issues related to the electron target

Comments

@AlexandraBuzila
Copy link
Contributor

Bug Description:

The Open dialog in the electron application is not modal. Multiple ones can be opened at the same time. This affects the Open File, Open Folder, Open Workspace commands.

Steps to Reproduce:

  1. Go to the File menu, select the Open File... menu entry. A dialog to select the file should open.
  2. Click outside the dialog, e.g. in the main window
  3. The dialog goes into the background and a new dialog can be opened via the Open File... command, while the first one is still open.

The expectation would be that the dialog is modal and remains on top of the main window until it's dismissed.
AlexandraBuzila added a commit to eclipsesource/theia that referenced this issue Feb 17, 2022
@AlexandraBuzila
electron: Open dialogs are not modal (eclipse-theia#10768)
604bbce 
Pass the electron BrowserWindow to the dialog.showOpenDialog command, to
make the dialog modal.


Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Feb 17, 2022
AlexandraBuzila added a commit to eclipsesource/theia that referenced this issue Feb 17, 2022
@AlexandraBuzila
electron: File dialogs are not modal (eclipse-theia#10768)
5f4e4c4 
- by default, pass the electron BrowserWindow to the
dialog.showOpenDialog and dialog.showSaveDialog commands, to make the
dialog modal
- add new `modal` property to the FileDialogProps


Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila added a commit to eclipsesource/theia that referenced this issue Feb 17, 2022
@AlexandraBuzila
electron: File dialogs are not modal (eclipse-theia#10768)
3a7ec9a 
- by default, pass the electron BrowserWindow to the
dialog.showOpenDialog and dialog.showSaveDialog commands, to make the
dialog modal
- add new `modal` property to the FileDialogProps


Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila added a commit to eclipsesource/theia that referenced this issue Feb 17, 2022
@AlexandraBuzila
electron: File dialogs are not modal (eclipse-theia#10768)
253fbd4 
- by default, pass the electron BrowserWindow to the
dialog.showOpenDialog and dialog.showSaveDialog commands, to make the
dialog modal
- add new `modal` property to the FileDialogProps


Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
vince-fugnitto pushed a commit that referenced this issue Feb 18, 2022
@AlexandraBuzila @vince-fugnitto
electron: File dialogs are not modal (#10768)
e8131aa 
- by default, pass the electron BrowserWindow to the
dialog.showOpenDialog and dialog.showSaveDialog commands, to make the
dialog modal
- add new `modal` property to the FileDialogProps


Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
@vince-fugnitto
Copy link
Member

Closed thanks to #10769.

@zole40 zole40 mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexandraBuzila @vince-fugnitto