Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot uninstall color theme plugins #11676

Open
msujew opened this issue Sep 16, 2022 · 1 comment
Open

Cannot uninstall color theme plugins #11676

msujew opened this issue Sep 16, 2022 · 1 comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system theming issues related to theming

Comments

@msujew
Copy link
Member

msujew commented Sep 16, 2022

Bug Description:

I didn't dive too deep into this issue, but noticed it while working on #11672. When uninstalling a color theme, the frontend contributions from that plugin aren't disposed at all. When reloading the application, the monaco theming service still thinks these color themes exist, and stores them in the indexed DB. After reloading the plugin has been disposed, but since the indexed DB still contains the themes, the theming service loads them from the indexed DB, making it effectively impossible to uninstall color themes.

Steps to Reproduce:

  1. Install a color theme
  2. Uninstall it
  3. Confirm that the color themes are still available for selection, even after reloading the application

Additional Information

  • Operating System: Windows
  • Theia Version: 1.29.0
@msujew msujew added theming issues related to theming plug-in system issues related to the plug-in system bug bugs found in the application labels Sep 16, 2022
@vince-fugnitto
Copy link
Member

I meant to open this a while ago but forgot, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system theming issues related to theming
Projects
None yet
Development

No branches or pull requests

2 participants