Improve theme preference selection #11678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11672
Changes the preferences for color theme and icon theme to use an enum. In order to facilitate label displaying and changing the associated preference schemas during runtime some more changes had to be performed:
enumItemLabels
inPreferenceSelectInput
updateSchemaProperty
method toPreferenceSchemaProvider
that triggers the associated change event.How to test
Note that uninstalling color themes doesn't work correctly due to #11676.
Review checklist
Reminder for reviewers