Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems Theia can't show debug evaluate errors, because of incorrect DAP error handling #11950

Closed
EvilBeaver opened this issue Dec 5, 2022 · 0 comments · Fixed by #11953
Closed
Labels
debug issues that related to debug functionality

Comments

@EvilBeaver
Copy link
Contributor

Bug Description:

When trying to evaluate expression in debugger, debug adapter can return success: false and error description. This is common thing that expressions can be misprinted and contain errors.

But, it seems Theia doesn't honor success flag of response https://github.com/eclipse-theia/theia/blob/master/packages/debug/src/browser/console/debug-console-items.tsx#L318 and shows error UI only in case of exception, which is not thrown in case of evaluation error.

Steps to Reproduce:

  1. Start debug session of some language and stop it on breakpoint
  2. Print something wrong and incorrect in "watch" widget
  3. Error is not shown, instead we see "not available" message

Expected, that real error is shown in an "error" manner, with Severity.Error

image

Reason: Theia tries to show a successful evaluation resultm which is "not available" because debug adapter returned error, not a result.

Additional Information

  • Operating System: any
  • Theia Version: Version 1.31.1 (Beta)
@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants