debug: fix watch expression errors
#11953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/fix-watch
branch
from
c59270d to
4e27361
Compare
msujew
reviewed
Dec 5, 2022
msujew
approved these changes
Dec 5, 2022
1 task
The commit updates `watch` expressions so we respect the proper error from the DAP and not hardcode to a value we define. The changes also update the styling to align with VS Code. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/fix-watch
branch
from
4e27361 to
1e25968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11950.
The pull-request updates handling for
watchexpressions to respect the error message rather than hardcode one.The changes also align the styling with VS Code.
How to test
*.spec.tsfilerun mocha testsdebug configurationwatchexpressions with variables that are known and unknownReview checklist
Reminder for reviewers