Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal: error thrown when attempting to set the default profile to '' #12119

Closed
vince-fugnitto opened this issue Jan 27, 2023 · 0 comments · Fixed by #12191 · 4 remaining pull requests
Closed

terminal: error thrown when attempting to set the default profile to '' #12119

vince-fugnitto opened this issue Jan 27, 2023 · 0 comments · Fixed by #12191 · 4 remaining pull requests
Assignees
@tsmaeder
Labels
terminal issues related to the terminal

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Following #12066 we have an error thrown on startup related to the default terminal-profile:

2023-01-27T13:29:59.848Z root ERROR Error: Cannot set default to unknown profile '' 
    at DefaultTerminalProfileService.setDefaultProfile (file:///home/foobar/workspaces/theia/examples/electron/lib/packages_terminal_lib_browser_terminal-profile-service_js-packages_terminal_lib_browser_termi-8fdc06.js:809:19)
    at file:///home/foobar/workspaces/theia/examples/electron/lib/packages_terminal_lib_browser_terminal-frontend-contribution_js.js:264:33
    at file:///home/foobar/workspaces/theia/examples/electron/lib/bundle.js:136667:69
    at CallbackList.invoke (file:///home/foobar/workspaces/theia/examples/electron/lib/bundle.js:136673:26)
    at Emitter.fire (file:///home/foobar/workspaces/theia/examples/electron/lib/bundle.js:136788:29)
    at DefaultTerminalProfileService.handleAdded (file:///home/foobar/workspaces/theia/examples/electron/lib/packages_terminal_lib_browser_terminal-profile-service_js-packages_terminal_lib_browser_termi-8fdc06.js:796:33)
    at file:///home/foobar/workspaces/theia/examples/electron/lib/packages_terminal_lib_browser_terminal-profile-service_js-packages_terminal_lib_browser_termi-8fdc06.js:769:26
    at file:///home/foobar/workspaces/theia/examples/electron/lib/bundle.js:136667:69

Steps to Reproduce:

You can view the error during CI

1.start the application with no previous default profile data
2. notice the error in the backend logs on startup
@vince-fugnitto vince-fugnitto added the terminal issues related to the terminal label Jan 27, 2023
@tsmaeder tsmaeder self-assigned this Feb 17, 2023
@tsmaeder tsmaeder mentioned this issue Feb 17, 2023
Merged
1 task
tsmaeder added a commit that referenced this issue Feb 21, 2023
@tsmaeder
Handle the case where no default terminal profile is set no startup. F…
798366f 
…ixes #12119

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
This was referenced Mar 22, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
2 participants
@tsmaeder @vince-fugnitto