nls: certain localizations are not always applied

[vince-fugnitto]

Bug Description:

There seems to be a regression where certain localizations are not applied.
I've noticed the following but there might be others:

theia/packages/core/src/browser/dialogs.ts

Line 73 in 4867d2a

export const CANCEL = nls.localizeByDefault('Cancel');

theia/packages/terminal/src/browser/terminal-frontend-contribution.ts

Line 682 in 4867d2a

label: nls.localizeByDefault('New Terminal'),

Steps to Reproduce:

1. start the application
2. use configure language display to change language besides english (ex: french)
3. confirm that the two user-facing strings are not localized

[msujew]

@vince-fugnitto It's likely due to the fact that the vscode version was bumped without me updating our nls.metadata.json file. VSCode language packs and this json files need to stay in sync to actually work as expected.

I'm currently on a longer vacation. But I'll be back on the 22nd and could take care of this.