Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nls metadata file for vscode version 1.77.0 #12555

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented May 22, 2023

What it does

Closes #12517.

Updates the nls.metadata.json file for version 1.77.0 of vscode. See also #12516.

How to test

The Lint CI passes, indicating no incorrect localization usages.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label May 22, 2023
@tsmaeder
Copy link
Contributor

@msujew if we update the API version in 1.37.2, this change should be cherry-picked, as well, right?

@tsmaeder
Copy link
Contributor

see #12518

@msujew
Copy link
Member Author

msujew commented May 23, 2023

@tsmaeder Preferably, yes.

@vince-fugnitto
Copy link
Member

@msujew would it be possible to add documentation on how to retrieve or produce the nls.metada.json file, perhaps as a wiki page? It would probably be useful for others to know how to perform the update if needed.

@msujew
Copy link
Member Author

msujew commented May 23, 2023

@vince-fugnitto Done :)

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for also taking the time to document the process!

@tsmaeder tsmaeder mentioned this pull request May 24, 2023
11 tasks
@msujew msujew merged commit 40ed192 into master May 24, 2023
@msujew msujew deleted the msujew/nls-1.77.0 branch May 24, 2023 08:11
@github-actions github-actions bot added this to the 1.38.0 milestone May 24, 2023
tsmaeder pushed a commit to tsmaeder/theia that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nls: certain localizations are not always applied
3 participants