Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nls metadata file for vscode version 1.77.0 #12555

Merged
merged 1 commit into from
May 24, 2023
Merged

Update nls metadata file for vscode version 1.77.0 #12555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/playwright/src/tests/theia-main-menu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ test.describe('Theia Main Menu', () => {
test("should show the menu items 'New File' and 'New Folder'", async () => {
const mainMenu = await menuBar.openMenu('File');
const menuItems = await mainMenu.visibleMenuItems();
expect(menuItems).toContain('New File');
expect(menuItems).toContain('New Folder');
expect(menuItems).toContain('New File...');
expect(menuItems).toContain('New Folder...');
});

test("should return menu item by name 'New File'", async () => {
const mainMenu = await menuBar.openMenu('File');
const menuItem = await mainMenu.menuItemByName('New File');
const menuItem = await mainMenu.menuItemByName('New File...');
expect(menuItem).toBeDefined();

const label = await menuItem?.label();
expect(label).toBe('New File');
expect(label).toBe('New File...');

const shortCut = await menuItem?.shortCut();
expect(shortCut).toBe(OSUtil.isMacOS ? '⌥ N' : 'Alt+N');
Expand All @@ -65,7 +65,7 @@ test.describe('Theia Main Menu', () => {

test('should detect whether menu item has submenu', async () => {
const mainMenu = await menuBar.openMenu('File');
const newFileItem = await mainMenu.menuItemByName('New File');
const newFileItem = await mainMenu.menuItemByName('New File...');
const settingsItem = await mainMenu.menuItemByName('Preferences');

expect(await newFileItem?.hasSubmenu()).toBe(false);
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/browser/common-frontend-contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ export class CommonFrontendContribution implements FrontendApplicationContributi

registry.registerMenuAction(CommonMenus.FILE_NEW, {
commandId: CommonCommands.NEW_UNTITLED_FILE.id,
label: nls.localizeByDefault('New File'),
label: nls.localizeByDefault('New File...'),
order: 'a'
});
}
Expand Down Expand Up @@ -1180,8 +1180,8 @@ export class CommonFrontendContribution implements FrontendApplicationContributi
protected async confirmRestart(languageName: string): Promise<boolean> {
const appName = FrontendApplicationConfigProvider.get().applicationName;
const shouldRestart = await new ConfirmDialog({
title: nls.localizeByDefault('Press the restart button to restart {0} and set the display language to {1}.', appName, languageName),
msg: nls.localizeByDefault('To change the display language, {0} needs to restart', appName),
title: nls.localizeByDefault('Restart {0} to switch to {1}?', appName, languageName),
msg: nls.localizeByDefault('To change the display language to {0}, {1} needs to restart.', languageName, appName),
ok: nls.localizeByDefault('Restart'),
cancel: Dialog.CANCEL,
}).open();
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/browser/core-preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export const corePreferenceSchema: PreferenceSchema = {
},
'workbench.editor.revealIfOpen': {
'type': 'boolean',
'description': nls.localizeByDefault('Controls whether an editor is revealed in any of the visible groups if opened. If disabled, an editor will prefer to open in the currently active editor group. If enabled, an already opened editor will be revealed instead of opened again in the currently active editor group. Note that there are some cases where this setting is ignored, e.g. when forcing an editor to open in a specific group or to the side of the currently active group.'),
'description': nls.localizeByDefault('Controls whether an editor is revealed in any of the visible groups if opened. If disabled, an editor will prefer to open in the currently active editor group. If enabled, an already opened editor will be revealed instead of opened again in the currently active editor group. Note that there are some cases where this setting is ignored, such as when forcing an editor to open in a specific group or to the side of the currently active group.'),
'default': false
},
'workbench.commandPalette.history': {
Expand Down
Loading