Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia is not seeing repository for workspace. #12651

Open
mcg1103 opened this issue Jun 26, 2023 · 12 comments
Open

Theia is not seeing repository for workspace. #12651

mcg1103 opened this issue Jun 26, 2023 · 12 comments
Labels
git issues related to git

Comments

@mcg1103
Copy link

mcg1103 commented Jun 26, 2023

Bug Description:

After opening a workspace that is a git repository, theia sees that there is a repository for this workspace.
after disconnecting from theia.. either with a restart of the theia or temporary disconnect from netowrk theia no longer
sees that the workspace is a git repository. After restarting theia or reconnecting to the network theia does not
reconize the workspace as a repository.

Local storage keys are cleared
theia:/:file:///home/mark/work/otwebg3:theia-git-selected-repository
and
theia:/:file:///home/mark/work/otwebg3:theia-git-all-repositories
delete the key and refresh and theia sees the repository.

Steps to Reproduce:

1.Open workspace that is a git repository
2.stop theia service
3.restart theia service
4.refresh browser.
5.workspace is not reconized as s git repository
6.delete local storage key theia:/:file:///home/mark/work/otwebg3:theia-git-all-repositories
7.refresh browser and repository is reconized.

Here is a video showing the issue.
https://youtu.be/ytWT-vI_12s

Additional Information

  • Operating System: Linux ubuntu 22.04
  • Theia Version: current main branch (june 25 2023)
@msujew msujew added the git issues related to git label Jun 26, 2023
@msujew
Copy link
Member

msujew commented Jun 26, 2023

@mcg1103 Does this issue appear with the @theia/git Theia extension only, or also with the vscode.git builtin extension? @theia/git is effectively in maintenance mode will likely be phased out in favor of the vscode builtin extensions. See also Theia Blueprint's package.json.

@mcg1103
Copy link
Author

mcg1103 commented Jun 26, 2023

@msujew I am using the browser example and that appears to be using @theia/git still.
It seems that 72e48cc is commit where this started.
-Mark

@msujew
Copy link
Member

msujew commented Jun 26, 2023

@mcg1103 You can always choose to not bundle the backend, by simply removing the backend config from the module.exports array. Note that we build/use the browser example for testing purposes only. For any real usage of Theia, refer to the Theia Blueprint App.

@mcg1103
Copy link
Author

mcg1103 commented Jun 26, 2023

@msujew Thanks for the info. I will look at the blueprint versions.
So this is not an issues? If using the vscode builtin extension this issue will not occure?
If so I will close this issue.

@msujew
Copy link
Member

msujew commented Jun 26, 2023

Well, it's an issue for sure, I was just trying to confirm under which circumstances it appears and how to potentially work around the issue. We should keep it open.

@mcg1103
Copy link
Author

mcg1103 commented Jun 26, 2023

Ok. I am a use of Theia not a developer of Theia. With that said i have used it for over year as my full time environment. I use it to develop on remote systems. I have been very happy with the environment.

So I don't really know how to add the vscode git builtin extensions. I was able to remove the @theia/git package and of course git no longer fuctions :-)

Will the vscode git builtin extensions be automaticlly included in future builds?

@msujew
Copy link
Member

msujew commented Jun 26, 2023

Theia does not come with any vscode extensions by default. You'll need to remove the exclude rule here.

@mcg1103
Copy link
Author

mcg1103 commented Jun 26, 2023

@msujew Not a conclusive test.... but when I remove @theia/git and remove the two exclude rules the problem goes away. The behavior is a bit different in that while disconnected from the server (offline), the repository name is no longer displayed in the status line. I believe this is the correct behavior but it is different from previous.

I will let you close the ticket if you wish or keep it open until patch to make work with theia package.

Thanks for all your help with this!
-Mark

@danepowell
Copy link
Contributor

I also found switching from @theia/git to the vscode git extension fixed this bug. Plus the vscode git extension has more features and seems better maintained.

@msujew
Copy link
Member

msujew commented Aug 8, 2023

For everyone else coming here, @theia/git is now being officially phased out (see #12745) and won't receive any updates in the near future. Please use the vscode.git extension as mentioned in the issue/above.

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 9, 2023

FWIW, I just observed the same with Blueprint 1.40.0 (with the git extension installed). The scenario is starting to use Theia again after the computer went to sleep for the night. We do seem to have trouble with this case, see also #12707

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 7, 2024

I suspect this depends on the git repo: I have some repos that the git extension recognizes consistently, whereas the theia repo is not seen at all. Maybe we need to update the git extension to some newer version of git?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
None yet
Development

No branches or pull requests

4 participants