Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @theia/git extension #12745

Open
5 of 7 tasks
JonasHelming opened this issue Jul 21, 2023 · 10 comments
Open
5 of 7 tasks

Deprecate @theia/git extension #12745

JonasHelming opened this issue Jul 21, 2023 · 10 comments
Labels
builtins Issues related to VS Code builtin extensions git issues related to git

Comments

@JonasHelming
Copy link
Contributor

JonasHelming commented Jul 21, 2023

As discussed in several dev calls, we would like to deprecate the @theia/git extension. It has a functional overlap with the VS Code built-in Git extension and it does not make sense to maintain our own Git extension anymore. This will reduce maintenance efforts.
If you are an active user of the Theia Git extension, we recommend you to evaluate switching to the VS Code built-in. If you see any issues with the switch, please raise them here.

@vince-fugnitto
Copy link
Member

Related #7482.

@vince-fugnitto vince-fugnitto added git issues related to git builtins Issues related to VS Code builtin extensions labels Jul 21, 2023
@colin-grant-work
Copy link
Contributor

I'd suggest that in addition to the issue that @vince-fugnitto has mentioned, any issues related to getting the VSCode builtin Git extensions & Gitlens working should be linked here so that adopters can be confident that the deprecation of @theia/git won't mean a loss of Git-related functionality.

@vince-fugnitto
Copy link
Member

any issues related to getting the VSCode builtin Git extensions & Gitlens working should be linked here

Such as missing menu support for the git builtins: #11730.

@tsmaeder
Copy link
Contributor

Didn't we have a repo where "community-supported" packages would live after removing them from the main repo?

@vince-fugnitto
Copy link
Member

Didn't we have a repo where "community-supported" packages would live after removing them from the main repo?

I'm not aware of any community-supported repo (although we can certainly create one if needed). I think the idea similarly to theia-cpp-extensions in the past is to move the package to it's own repository where interested parties can contribute and maintain the package.

@Hanksha
Copy link
Contributor

Hanksha commented Mar 1, 2024

Hi, is it still worth reporting and fixing issues related to @theia/git ?

I was planning to use the vs code extension but it's not working yet and we're getting too close to our release to perform the switch. We found a few issues in @theia/git but since the package is being deprecated I'm not sure if I should contribute the fix or just implement a workaround in our project until we can use the vs code extension.

@msujew
Copy link
Member

msujew commented Mar 1, 2024

@Hanksha I don't really think it's worth it. Instead, it would be more beneficial to report/fix issues with the vscode.git extension.

@Hanksha
Copy link
Contributor

Hanksha commented Mar 1, 2024

@msujew Ok thanks.

@JonasHelming
Copy link
Contributor Author

@jfaltermeier It is not marked as deprecated anymore: https://www.npmjs.com/package/@theia/git
Do we have to repeat this for every new version maybe?

JonasHelming added a commit that referenced this issue Dec 17, 2024
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>

#12745
@jfaltermeier
Copy link
Contributor

@jfaltermeier It is not marked as deprecated anymore: https://www.npmjs.com/package/@theia/git Do we have to repeat this for every new version maybe?

The guide does not mention this case (https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions), but it looks like it. It will add this to the documentation

JonasHelming added a commit that referenced this issue Dec 18, 2024
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>

#12745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions git issues related to git
Projects
None yet
Development

No branches or pull requests

7 participants