Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate preview support for markdown files #13895

Open
msujew opened this issue Jul 8, 2024 · 4 comments
Open

Deprecate preview support for markdown files #13895

msujew opened this issue Jul 8, 2024 · 4 comments
Labels
markdown issues related to markdown preview issues related to the preview proposal feature proposals (potential future features)

Comments

@msujew
Copy link
Member

msujew commented Jul 8, 2024

Since we're now deprecating the Git extension (#12745) in favor of using VS Code's builtins, I'm wondering whether it makes sense to remove the markdown preview feature from the @theia/preview package. IMO it's a worse version of the vscode.markdown builtin extension and bloats the bundle due to the inclusion of highlight.js (and its 1.3mb minified bundle size).

@msujew msujew added preview issues related to the preview markdown issues related to markdown proposal feature proposals (potential future features) labels Jul 8, 2024
@msujew
Copy link
Member Author

msujew commented Jul 16, 2024

This has been discussed in last weeks dev call. We will likely deprecate/remove the feature after sending out an info about this via the Theia mailing list.

I aim to remove the related code for the August (1.53) release.

@zhouxinghong
Copy link

@msujew I've asked VSCode many times about these problems but they refused to deal with them, besides VSCode is very bloated and slow now, so when I found Theia I decided to abandon VSCode completely and move to Theia, I hope that the birth of the Theia project means that it's an enhancement and improvement of VSCode, at least in some ways, it should have its own unique features. I hope that the Theia project is meant to be an enhanced and improved version of VSCode, at least in some ways.
I hope you will consider these suggestions.

Thank you very much for your hard work! 👍😜👏

@zhouxinghong
Copy link

image
The preview button with the arrow pointing to it has very complete support for audio and video previews, and the previews are much better than the vscode Markdown previews, so please keep this feature. Also, vscode Markdown is a feature-crippled presence, consider removing the vscode Markdown preview.

@zhouxinghong
Copy link

zhouxinghong commented Sep 18, 2024

Version 1.53.200
Windows 10 19044

Hello my friend! Please allow users to remove unnecessary buttons.
For example, use the button pointed by the red scissors:

Because it calls the Markdown preview function that comes with VSCode, after a long period of testing and use, it is found that the Markdown preview function that comes with VSCode is a broken, outdated and incomplete existence, so please delete it.

image

Please remove this old right-click menu item.
Because it calls the Markdown preview function that comes with VSCode, after a long period of testing and use, it is found that the Markdown preview function that comes with VSCode is a broken, outdated and incomplete existence, so please delete it.
image
image

image

Please remove this old preview option.
Because it calls the Markdown preview function that comes with VSCode, after a long period of testing and use, it is found that the Markdown preview function that comes with VSCode is a broken, outdated and incomplete existence, so please delete it.
image

Version 1.53.200
Windows 10 19044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markdown issues related to markdown preview issues related to the preview proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

2 participants