Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor][diagnostics] Support error/warning marker in the editor tabs #1278

Closed
kittaakos opened this issue Feb 14, 2018 · 0 comments · Fixed by #5845
Closed

[editor][diagnostics] Support error/warning marker in the editor tabs #1278

kittaakos opened this issue Feb 14, 2018 · 0 comments · Fixed by #5845
Assignees
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves

Comments

@kittaakos
Copy link
Contributor

It would be great to support error/warning markers on the editor tabs. We could overlay a decorator icon on the original one. Just like in Eclipse.

screen shot 2018-02-14 at 17 01 45

screen shot 2018-02-14 at 17 05 30

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves editor issues related to the editor labels Feb 14, 2018
@fangnx fangnx self-assigned this Jul 23, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 2, 2019
Fixed eclipse-theia#1278: implemented error marker for editor tabs
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 5, 2019
Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 5, 2019
Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 7, 2019
Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 7, 2019
Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 8, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 8, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 8, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 12, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 13, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 13, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 14, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 15, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 15, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 15, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 20, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 20, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 20, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 21, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 21, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 21, 2019
…ror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 22, 2019
…rror marker in editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
vince-fugnitto pushed a commit that referenced this issue Aug 22, 2019
…n editor tabs

- Implemented `TabBarDecorator` that provides tabs with decorations, similar to what we already had for tree nodes.
- Supported diagnostic problem markers (error, warning, ...) in editor tabs in the main area. Tabs in side bars can be decorated as well in the future using the same code.
- Refactored `TreeDecoration` to a more generic `NodeDecoration`, which is currently used for decorating tree nodes and tabbar tabs.

Signed-off-by: fangnx <naxin.fang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants