Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preference editor take up a lot of memory #12789

Closed
fanyipin opened this issue Aug 1, 2023 · 0 comments · Fixed by #12790
Closed

preference editor take up a lot of memory #12789

fanyipin opened this issue Aug 1, 2023 · 0 comments · Fixed by #12790
Labels
performance issues related to performance preferences issues related to preferences

Comments

@fanyipin
Copy link
Contributor

fanyipin commented Aug 1, 2023

Bug Description:

image

When checking the memory of browserwindow, I find that markdownit will occupy a lot of memory over 100M in preference editor, mainly because linkify has a large number of instances, and each instance corresponds to many regular expressions as shown in the figure above. I wonder if this can be optimized:

  1. Check whether a single markdownit instance can meet the requirements
  2. Whether multiple markdownit instances can share a linkify regular expression set
  3. Can markdownRenderer be destroyed after preference editor rendering is completed

Additional Information

  • Operating System:
  • Theia Version: 1.39
@vince-fugnitto vince-fugnitto added preferences issues related to preferences performance issues related to performance labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance issues related to performance preferences issues related to preferences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants