Reuse markdown instance for preferences widget #12790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12789
The current implementation creates a new instance of
markdownit
for every preference leaf node. This is quite costly in frontend memory. The change moves themarkdownit
instance to a dedicated service that is shared across all nodes in a preference model.In my tests, this reduces the memory consumption of the preference widget by ~165MB:
Before (267MB):
After (102MB):
How to test
Review checklist
Reminder for reviewers