Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: cancelling file-saving dialog incorrectly closes dirty editor #12859

Closed
vladarama opened this issue Aug 24, 2023 · 0 comments · Fixed by #12864
Closed

bug: cancelling file-saving dialog incorrectly closes dirty editor #12859

vladarama opened this issue Aug 24, 2023 · 0 comments · Fixed by #12864
Labels
bug bugs found in the application

Comments

@vladarama
Copy link
Contributor

vladarama commented Aug 24, 2023 •
edited
Loading

Bug Description:

When trying to close a dirty untitled editor, cancelling the file-saving dialog incorrectly closes the editor. The correct behavior would be to leave the dirty editor opened.

Demo:
closing dirty untitled editor

Steps to Reproduce:

  1. Open Theia application.
  2. Create a new untitled text file (File -> New Text File or Alt+N).
  3. Try to close the editor by pressing the X or Alt+W.
  4. The file saving dialog should appear -> Press Cancel.
  5. The editor is incorrectly closed.

Additional Information

  • Operating System: Windows 10
  • Theia Version: 1.40
@vince-fugnitto vince-fugnitto added the bug bugs found in the application label Aug 24, 2023
@vladarama vladarama mentioned this issue Aug 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: file-saving dialog with dirty editors vladarama/theia
2 participants
@vince-fugnitto @vladarama