fix: file-saving dialog with dirty editors #12864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where cancelling the file-saving dialog incorrectly closes the editor. Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
msujew
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Interestingly enough, I now have the exact opposite issue: When closing an untitled file and saving it to a new location, the editor isn't closed. Instead the model now points to the newly created file. VSCode correctly closes the editor after saving the untitled file.
|
@vladarama Are you planning to make this other fix part of this PR? |
|
@JonasHelming |
msujew
approved these changes
Oct 12, 2023
This commit fixes the issue where cancelling the file-saving dialog incorrectly closes the editor. Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
msujew
force-pushed
the
editor-closing
branch
from
b4e91d1 to
8827d4b
Compare
|
@vince-fugnitto Do you want to merge this? |
msujew
requested changes
Oct 24, 2023
|
@vince-fugnitto Do you want to merge this now? |
@JonasHelming sure, we can merge for the release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12859
This PR fixes a bug where cancelling the file-saving dialog when closing a dirty editor would actually close the editor.
With the new changes, cancelling the dialog will leave the dirty editor opened, which is the intended behavior.
How to test
File->New Text FileorAlt+N).XorAlt+W.Cancel.Review checklist
Reminder for reviewers