Custom icons are not displayed in plugin view

[bvenreply]

Bug Description:

Custom icons are not displayed in plugin views. It seems that (some?) custom icons are displayed as inline elements by default, thus ignoring the width property.

Steps to Reproduce:

The most mainstream vscode extension I could reproduce the issue with was ms-kubernetes-tools. If you have no Kubernetes clusters, you can have one displayed using this dummy kubeconfig:

apiVersion: v1
kind: Config
current-context: dev
preferences: {}
clusters:
  - cluster:
      server: https://fake-k8s.com.local
    name: dev
users:
  - name: dev
    user:
      token: dummy
contexts:
  - name: dev
    context:
      cluster: dev
      user: dev

Just save it somewhere, then add it with the command Kubernetes: Set Kubeconfig.

Then just open the Kubernetes plugin view and note the missing icon to the left of the cluster name, as compared to vscode.

Additional Information

• Theia Version: 1.43.1
• Browser: Chromium version 119.0.6045.159

I believe the issue was introduced with this change, in this PR: /pull/12827 . I tested setting the display mode explicitly to something other than inline, the icons were displayed correctly in that case (see image above).

[bvenreply]

setting the display mode explicitly to something other than inline, the icons were displayed correctly in that case (see image above).

I had another look, it seems that as of merging #13014 this is no longer true on master, as neither width nor height are being set on this pseudo-element anymore.