Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions View does not update as expected #13320

Closed
jfaltermeier opened this issue Jan 26, 2024 · 4 comments · Fixed by #13337
Closed

Extensions View does not update as expected #13320

jfaltermeier opened this issue Jan 26, 2024 · 4 comments · Fixed by #13337
Milestone
1.47.0

Comments

@jfaltermeier
Copy link
Contributor

Bug Description:

When I install or uninstall an extension, the UI does not update as expected.
Tested with Electron

Peek 2024-01-26 08-51

Steps to Reproduce:

  1. Uninstall or Install an extension from VSX
  2. After this is done, the button does not update as expected

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: 1.46.0
@jfaltermeier jfaltermeier mentioned this issue Jan 26, 2024
Merged
1 task
@msujew
Copy link
Member

msujew commented Jan 31, 2024

Probably a regression from #13138.

@xai
Copy link
Contributor

xai commented Jan 31, 2024 •
edited
Loading

Probably a regression from #13138.

It is, yes. I bisected it down to that. Commits prior to that do not have the issue.
We are having some dependency injection issues here. It also happens in the browser example, which also produces respective frontend logs indicating binding problems.

The first one is in

theia/packages/plugin-ext/src/hosted/browser/worker/worker-main.ts

Line 59 in b15b639

const rpc: RPCProtocol = container.get(RPCProtocolImpl);

where RPCProtocolImpl instead of RPCProtocol is used (Christian spotted that yesterday),
but there is more. Currently, I have trouble with the binding of MinimalTerminalServiceExt.

xai added a commit to eclipsesource/theia that referenced this issue Jan 31, 2024
@xai @cdamus
fix: resolve dependency injection issues
6b0cba4 
Fixes eclipse-theia#13320

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
@xai xai mentioned this issue Jan 31, 2024
Merged
1 task
@xai
Copy link
Contributor

xai commented Jan 31, 2024

Okay, apparently, dependency injection issues are not the only reason for this. I started a draft PR that resolves the DI-related issues, but the bug is still present.

cdamus added a commit to eclipsesource/theia that referenced this issue Jan 31, 2024
@xai @cdamus
fix: regressions from headless plugins refactoring
d3e52f7 
- fix gaps in Inversify DI configuration in the web worker for
  frontend plugins
- restore the onDidDeploy() dorwarding lost in the refactoring for
  headless plugins

Fixes eclipse-theia#13320

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
cdamus added a commit to eclipsesource/theia that referenced this issue Jan 31, 2024
@xai @cdamus
fix: regressions from headless plugins refactoring
ca5b445 
- fix gaps and errors in Inversify DI configuration in the web worker
  for frontend plugins
- restore the onDidDeploy() forwarding lost in the refactoring for
  headless plugins

Fixes eclipse-theia#13320

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
@cdamus
Copy link
Contributor

cdamus commented Jan 31, 2024

The crux of the problem was that the Headless Plugins refactoring lost the forwarding of onDidDeploy() events from the frontend HostedPluginSupport to the HostedPluginWatcher. With that restored, the issue seems to be resolved.

JonasHelming pushed a commit that referenced this issue Feb 1, 2024
@xai @cdamus
fix: regressions from headless plugins refactoring (#13337)
9a51317 
- fix gaps and errors in Inversify DI configuration in the web worker
  for frontend plugins
- restore the onDidDeploy() forwarding lost in the refactoring for
  headless plugins

Fixes #13320

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
jfaltermeier pushed a commit that referenced this issue Feb 6, 2024
@xai @cdamus @jfaltermeier
fix: regressions from headless plugins refactoring (#13337)
1799210 
- fix gaps and errors in Inversify DI configuration in the web worker
  for frontend plugins
- restore the onDidDeploy() forwarding lost in the refactoring for
  headless plugins

Fixes #13320

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.47.0
Development

Successfully merging a pull request may close this issue.

fix: regressions from headless plugins refactoring eclipsesource/theia
4 participants
@xai @cdamus @msujew @jfaltermeier