Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] TestRunProfile now fires an event when isDefault is changed with 1.86 #13354

Closed
Tracked by #13356
rschnekenbu opened this issue Feb 6, 2024 · 0 comments · Fixed by #13388
Closed
Tracked by #13356

[vscode] TestRunProfile now fires an event when isDefault is changed with 1.86 #13354

rschnekenbu opened this issue Feb 6, 2024 · 0 comments · Fixed by #13388
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility
Milestone
1.47.0

Comments

@rschnekenbu
Copy link
Contributor

TestRunProfile can now provide a onDidChangeDefault event when isDefault is changed.

see https://github.com/microsoft/vscode/blob/e5447598324c57ac814c150148e7e4c830e0f9ee/src/vscode-dts/vscode.d.ts#L17156
This was referenced Feb 6, 2024
Closed
Closed
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Feb 6, 2024
@rschnekenbu rschnekenbu self-assigned this Feb 7, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 14, 2024
@rschnekenbu
Add support for TestRunProfile onDidChangeProfile
6ae403b 
add support to changing default profile in service
add event for isDefault onDidChangeProfile
add command to change default profile

fixes eclipse-theia#13354

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Feb 14, 2024
Merged
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 14, 2024
@rschnekenbu
Add support for TestRunProfile onDidChangeProfile
c5ad6a9 
add support to changing default profile in service
add event for isDefault onDidChangeProfile
add command to change default profile

fixes eclipse-theia#13354

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 28, 2024
@rschnekenbu
Add support for TestRunProfile onDidChangeProfile
f1d3e36 
add support to changing default profile in service
add event for isDefault onDidChangeProfile
add command to change default profile

fixes eclipse-theia#13354

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>

address review comments

reduce code
rschnekenbu added a commit that referenced this issue Feb 28, 2024
@rschnekenbu
Add support for TestRunProfile onDidChangeProfile (#13388)
ddc7257 
add support to changing default profile in service
add event for isDefault onDidChangeProfile
add command to change default profile

fixes #13354

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.47.0
Development

Successfully merging a pull request may close this issue.

[vscode] Add support for TestRunProfile onDidChangeProfile event eclipsesource/theia
2 participants
@rschnekenbu @jfaltermeier