Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia not synchronize the background color of the electron window when changing the theme #14428

Closed
lqd1434 opened this issue Nov 11, 2024 · 2 comments · Fixed by #14491
Closed
Assignees

Comments

@lqd1434
Copy link

lqd1434 commented Nov 11, 2024

Bug Description:

Theia not synchronize the background color of the electron window when changing the theme

Steps to Reproduce:

1.open theia ide
2.change theme to dark
3.refresh window ,and we can see a white screen flash then become dark

Additional Information

this issue can fixed by follow code

// core/src/electron-main/electron-main-application
override setBackgroundColor(webContents: WebContents, backgroundColor: string): void {
        BrowserWindow.fromWebContents(webContents)?.setBackgroundColor(backgroundColor);
        this.customBackgroundColor = backgroundColor;
        this.saveState(webContents);
    }

This seems like a simple fix, I wonder if theia has other considerations or if it's just me got the issue

  • Operating System: ubuntu22
  • Theia Version: latest
@JonasHelming
Copy link
Contributor

@rschnekenbu

@rschnekenbu rschnekenbu self-assigned this Nov 12, 2024
@Keithyumi
Copy link

Can we change theia's background colour? When using the light theme, when the page hasn't loaded yet, it will show a white screen, which makes the application look especially slow, and it won't feel so strong if it's a black background!
image

rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 20, 2024
fix: eclipse-theia#14428

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 20, 2024
fix: eclipse-theia#14428

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit that referenced this issue Nov 26, 2024
fix: #14428

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants